* [PATCH] vmlfb: use list_move_tail instead of list_del/list_add_tail
@ 2012-09-05 6:40 Wei Yongjun
2012-09-23 19:41 ` Florian Tobias Schandinat
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-05 6:40 UTC (permalink / raw)
To: linux-fbdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/video/vermilion/vermilion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/vermilion/vermilion.c b/drivers/video/vermilion/vermilion.c
index 970e43d..083f0c8 100644
--- a/drivers/video/vermilion/vermilion.c
+++ b/drivers/video/vermilion/vermilion.c
@@ -1168,8 +1168,7 @@ void vmlfb_unregister_subsys(struct vml_sys *sys)
list_for_each_entry_safe(entry, next, &global_has_mode, head) {
printk(KERN_DEBUG MODULE_NAME ": subsys disable pipe\n");
vmlfb_disable_pipe(entry);
- list_del(&entry->head);
- list_add_tail(&entry->head, &global_no_mode);
+ list_move_tail(&entry->head, &global_no_mode);
}
mutex_unlock(&vml_mutex);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] vmlfb: use list_move_tail instead of list_del/list_add_tail
2012-09-05 6:40 [PATCH] vmlfb: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
@ 2012-09-23 19:41 ` Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-09-23 19:41 UTC (permalink / raw)
To: linux-fbdev
On 09/05/2012 06:40 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/vermilion/vermilion.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/vermilion/vermilion.c b/drivers/video/vermilion/vermilion.c
> index 970e43d..083f0c8 100644
> --- a/drivers/video/vermilion/vermilion.c
> +++ b/drivers/video/vermilion/vermilion.c
> @@ -1168,8 +1168,7 @@ void vmlfb_unregister_subsys(struct vml_sys *sys)
> list_for_each_entry_safe(entry, next, &global_has_mode, head) {
> printk(KERN_DEBUG MODULE_NAME ": subsys disable pipe\n");
> vmlfb_disable_pipe(entry);
> - list_del(&entry->head);
> - list_add_tail(&entry->head, &global_no_mode);
> + list_move_tail(&entry->head, &global_no_mode);
> }
> mutex_unlock(&vml_mutex);
> }
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-23 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-05 6:40 [PATCH] vmlfb: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2012-09-23 19:41 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).