linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
	'Ajay Kumar' <ajaykumar.rs@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
	FlorianSchandinat@gmx.de, thomas.ab@samsung.com,
	'devicetree-discuss' <devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver
Date: Fri, 28 Sep 2012 08:25:39 +0000	[thread overview]
Message-ID: <50655F03.6000700@samsung.com> (raw)
In-Reply-To: <1511551.R6uMubmq1B@flatron>

On 09/28/2012 08:48 AM, Tomasz Figa wrote:
>>>> +	display-port-controller {
>>>> +		compatible = "samsung,exynos5-dp";
>>>> +		reg =<0x145B0000 0x10000>;
>>>> +		interrupts =<10 3>;
>>>> +		interrupt-parent =<&combiner>;
>>>> +		dp_phy =<&dptx_phy>;
>>>
>>> Shouldn't it be "samsung,dp_phy" ?
>>
>> Do you mean this ? It is not working.
>> +		dp_phy = "samsung,dp_phy";
> 
> I believe he meant:
> 
> -+		dp_phy =<&dptx_phy>;
> ++		samsung,dp_phy =<&dptx_phy>;
> 
> to mark that this is a Samsung-specific property.

Yes, that's what I meant. Sorry for imprecise wording.

Regards,
Sylwester

  parent reply	other threads:[~2012-09-28  8:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 12:45 [PATCH V3] video: exynos_dp: Add device tree support to DP driver Ajay Kumar
2012-09-27  7:58 ` Jingoo Han
     [not found] ` <1348515385-22332-1-git-send-email-ajaykumar.rs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-27 13:44   ` Sylwester Nawrocki
2012-09-28  0:11     ` Jingoo Han
2012-09-28  6:48       ` Tomasz Figa
2012-09-28  8:09         ` Jingoo Han
2012-09-28  8:25         ` Sylwester Nawrocki [this message]
2012-10-01  5:52       ` Ajay kumar
2012-10-04  1:50         ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50655F03.6000700@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=ajaykumar.rs@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.ab@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).