[PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable

linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads()
@ 2012-10-16 11:51 Peter Ujfalusi
  2012-10-16 13:31 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2012-10-16 11:51 UTC (permalink / raw)
  To: Tomi Valkeinen
  Cc: Florian Tobias Schandinat, linux-fbdev, linux-omap, linux-kernel

Appear to be a copy-paste bug: the code was checking board_data->dsi_enable_pads
while calling board_data->dsi_disable_pads.


Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---

Hi Tomi,

not sure if this need to be included to 3.7

Regards,
Peter

 drivers/video/omap2/dss/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index b2af72d..7afaf61 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -122,7 +122,7 @@ void dss_dsi_disable_pads(int dsi_id, unsigned lane_mask)
 {
 	struct omap_dss_board_info *board_data = core.pdev->dev.platform_data;
 
-	if (!board_data->dsi_enable_pads)
+	if (!board_data->dsi_disable_pads)
 		return;
 
 	return board_data->dsi_disable_pads(dsi_id, lane_mask);
-- 
1.7.12.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads()
  2012-10-16 11:51 [PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads() Peter Ujfalusi
@ 2012-10-16 13:31 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2012-10-16 13:31 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: Florian Tobias Schandinat, linux-fbdev, linux-omap, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

On 2012-10-16 14:51, Peter Ujfalusi wrote:
> Appear to be a copy-paste bug: the code was checking board_data->dsi_enable_pads
> while calling board_data->dsi_disable_pads.
> 
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> 
> Hi Tomi,
> 
> not sure if this need to be included to 3.7

Thanks. Probably not needed for 3.7, as we never hit that bug with the
current kernel: if dsi_enable_pads is defined we also always define
dsi_disable_pads.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-16 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-16 11:51 [PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads() Peter Ujfalusi
2012-10-16 13:31 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).