* [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs()
@ 2012-10-21 12:54 Wei Yongjun
2012-10-22 6:14 ` Sumit Semwal
2012-10-22 6:53 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-10-21 12:54 UTC (permalink / raw)
To: tomi.valkeinen, FlorianSchandinat; +Cc: yongjun_wei, linux-omap, linux-fbdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock on the error handling path in function
hdmi_dump_regs().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
no test
---
drivers/video/omap2/dss/hdmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index a48a7dd..8c9b8b3 100644
--- a/drivers/video/omap2/dss/hdmi.c
+++ b/drivers/video/omap2/dss/hdmi.c
@@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s)
{
mutex_lock(&hdmi.lock);
- if (hdmi_runtime_get())
+ if (hdmi_runtime_get()) {
+ mutex_unlock(&hdmi.lock);
return;
+ }
hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s);
hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs()
2012-10-21 12:54 [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs() Wei Yongjun
@ 2012-10-22 6:14 ` Sumit Semwal
2012-10-22 6:53 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Sumit Semwal @ 2012-10-22 6:14 UTC (permalink / raw)
To: Wei Yongjun
Cc: tomi.valkeinen, FlorianSchandinat, yongjun_wei, linux-omap,
linux-fbdev
On Sunday 21 October 2012 06:24 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock on the error handling path in function
> hdmi_dump_regs().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good to me; feel free to add:
Reviewed-by: Sumit Semwal <sumit.semwal@ti.com>
> ---
> no test
> ---
> drivers/video/omap2/dss/hdmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
> index a48a7dd..8c9b8b3 100644
> --- a/drivers/video/omap2/dss/hdmi.c
> +++ b/drivers/video/omap2/dss/hdmi.c
> @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s)
> {
> mutex_lock(&hdmi.lock);
>
> - if (hdmi_runtime_get())
> + if (hdmi_runtime_get()) {
> + mutex_unlock(&hdmi.lock);
> return;
> + }
>
> hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s);
> hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs()
2012-10-21 12:54 [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs() Wei Yongjun
2012-10-22 6:14 ` Sumit Semwal
@ 2012-10-22 6:53 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2012-10-22 6:53 UTC (permalink / raw)
To: Wei Yongjun; +Cc: FlorianSchandinat, yongjun_wei, linux-omap, linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On 2012-10-21 15:54, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock on the error handling path in function
> hdmi_dump_regs().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> no test
> ---
> drivers/video/omap2/dss/hdmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
> index a48a7dd..8c9b8b3 100644
> --- a/drivers/video/omap2/dss/hdmi.c
> +++ b/drivers/video/omap2/dss/hdmi.c
> @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s)
> {
> mutex_lock(&hdmi.lock);
>
> - if (hdmi_runtime_get())
> + if (hdmi_runtime_get()) {
> + mutex_unlock(&hdmi.lock);
> return;
> + }
>
> hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s);
> hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);
>
Thanks, applied to omapdss tree.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-22 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-21 12:54 [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs() Wei Yongjun
2012-10-22 6:14 ` Sumit Semwal
2012-10-22 6:53 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).