From: Rob Herring <robherring2@gmail.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
kernel@pengutronix.de
Subject: Re: [PATCH v7 0/8] of: add display helper
Date: Thu, 08 Nov 2012 21:35:47 +0000 [thread overview]
Message-ID: <509C25B3.5060509@gmail.com> (raw)
In-Reply-To: <1351675689-26814-1-git-send-email-s.trumtrar@pengutronix.de>
On 10/31/2012 04:28 AM, Steffen Trumtrar wrote:
> Hi!
>
> Finally, v7 of the series.
>
> Changes since v6:
> - get rid of some empty lines etc.
> - move functions to their subsystems
> - split of_ from non-of_ functions
> - add at least some kerneldoc to some functions
>
> Regards,
> Steffen
>
>
> Steffen Trumtrar (8):
> video: add display_timing struct and helpers
> of: add helper to parse display timings
> of: add generic videomode description
> video: add videomode helpers
> fbmon: add videomode helpers
> fbmon: add of_videomode helpers
> drm_modes: add videomode helpers
> drm_modes: add of_videomode helpers
>
> .../devicetree/bindings/video/display-timings.txt | 139 +++++++++++++++
> drivers/gpu/drm/drm_modes.c | 78 +++++++++
> drivers/of/Kconfig | 12 ++
> drivers/of/Makefile | 2 +
> drivers/of/of_display_timings.c | 185 ++++++++++++++++++++
> drivers/of/of_videomode.c | 47 +++++
Not sure why you moved this, but please move this back to drivers/video.
We're trying to move subsystem specific pieces out of drivers/of.
Rob
> drivers/video/Kconfig | 11 ++
> drivers/video/Makefile | 2 +
> drivers/video/display_timing.c | 24 +++
> drivers/video/fbmon.c | 76 ++++++++
> drivers/video/videomode.c | 44 +++++
> include/drm/drmP.h | 8 +
> include/linux/display_timing.h | 69 ++++++++
> include/linux/fb.h | 5 +
> include/linux/of_display_timings.h | 20 +++
> include/linux/of_videomode.h | 15 ++
> include/linux/videomode.h | 36 ++++
> 17 files changed, 773 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/display-timings.txt
> create mode 100644 drivers/of/of_display_timings.c
> create mode 100644 drivers/of/of_videomode.c
> create mode 100644 drivers/video/display_timing.c
> create mode 100644 drivers/video/videomode.c
> create mode 100644 include/linux/display_timing.h
> create mode 100644 include/linux/of_display_timings.h
> create mode 100644 include/linux/of_videomode.h
> create mode 100644 include/linux/videomode.h
>
next prev parent reply other threads:[~2012-11-08 21:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 9:28 [PATCH v7 0/8] of: add display helper Steffen Trumtrar
2012-10-31 9:28 ` [PATCH v7 1/8] video: add display_timing struct and helpers Steffen Trumtrar
2012-10-31 17:04 ` Laurent Pinchart
2012-10-31 17:09 ` Laurent Pinchart
[not found] ` <1351675689-26814-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-01 20:08 ` Thierry Reding
2012-11-04 16:53 ` Steffen Trumtrar
2012-10-31 9:28 ` [PATCH v7 2/8] of: add helper to parse display timings Steffen Trumtrar
2012-11-01 17:52 ` Stephen Warren
2012-11-01 20:15 ` Thierry Reding
[not found] ` <20121101201510.GB13137-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-04 17:10 ` Steffen Trumtrar
2012-11-02 17:31 ` Leela Krishna Amudala
2012-11-04 17:23 ` Steffen Trumtrar
2012-10-31 9:28 ` [PATCH v7 3/8] of: add generic videomode description Steffen Trumtrar
2012-11-01 20:17 ` Thierry Reding
2012-10-31 9:28 ` [PATCH v7 4/8] video: add videomode helpers Steffen Trumtrar
2012-10-31 17:18 ` Laurent Pinchart
2012-10-31 9:28 ` [PATCH v7 5/8] fbmon: " Steffen Trumtrar
2012-10-31 15:30 ` Manjunathappa, Prakash
2012-10-31 16:49 ` Steffen Trumtrar
2012-11-08 21:25 ` Steffen Trumtrar
[not found] ` <20121108212545.GA32605-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-09 16:54 ` Manjunathappa, Prakash
2012-11-09 19:31 ` Steffen Trumtrar
2012-11-12 11:46 ` Laurent Pinchart
2012-10-31 9:28 ` [PATCH v7 6/8] fbmon: add of_videomode helpers Steffen Trumtrar
2012-10-31 9:28 ` [PATCH v7 7/8] drm_modes: add videomode helpers Steffen Trumtrar
2012-10-31 9:28 ` [PATCH v7 8/8] drm_modes: add of_videomode helpers Steffen Trumtrar
2012-11-05 9:10 ` Thierry Reding
2012-11-08 21:35 ` Rob Herring [this message]
2012-11-09 8:22 ` [PATCH v7 0/8] of: add display helper Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509C25B3.5060509@gmail.com \
--to=robherring2@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=g.liakhovetski@gmx.de \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).