* [PATCH] da8xx: Fix revision check on the da8xx driver
@ 2012-10-30 18:14 Pantelis Antoniou
2012-10-31 3:51 ` Manjunathappa, Prakash
0 siblings, 1 reply; 4+ messages in thread
From: Pantelis Antoniou @ 2012-10-30 18:14 UTC (permalink / raw)
To: Florian Tobias Schandinat
Cc: Pantelis Antoniou, linux-fbdev, linux-kernel, Koen Kooi,
Matt Porter, Russ Dill, linux-omap
The revision check fails for the beaglebone; Add new revision ID.
Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
drivers/video/da8xx-fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
lcd_revision = LCD_VERSION_1;
break;
case 0x4F200800:
+ case 0x4F201000:
lcd_revision = LCD_VERSION_2;
break;
default:
--
1.7.12
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] da8xx: Fix revision check on the da8xx driver
2012-10-30 18:14 [PATCH] da8xx: Fix revision check on the da8xx driver Pantelis Antoniou
@ 2012-10-31 3:51 ` Manjunathappa, Prakash
2012-12-04 6:36 ` Manjunathappa, Prakash
0 siblings, 1 reply; 4+ messages in thread
From: Manjunathappa, Prakash @ 2012-10-31 3:51 UTC (permalink / raw)
To: Pantelis Antoniou, Florian Tobias Schandinat
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Koen Kooi, Porter, Matt, Dill, Russ, linux-omap@vger.kernel.org
On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
> The revision check fails for the beaglebone; Add new revision ID.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> drivers/video/da8xx-fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index 80665f6..866d804 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
> lcd_revision = LCD_VERSION_1;
> break;
> case 0x4F200800:
> + case 0x4F201000:
Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
with to one read(0x4F200800) on emulator platform.
Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> lcd_revision = LCD_VERSION_2;
> break;
> default:
> --
> 1.7.12
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] da8xx: Fix revision check on the da8xx driver
2012-10-31 3:51 ` Manjunathappa, Prakash
@ 2012-12-04 6:36 ` Manjunathappa, Prakash
2012-12-04 9:18 ` Tomi Valkeinen
0 siblings, 1 reply; 4+ messages in thread
From: Manjunathappa, Prakash @ 2012-12-04 6:36 UTC (permalink / raw)
To: Pantelis Antoniou, Florian Tobias Schandinat, Valkeinen, Tomi
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Koen Kooi, Porter, Matt, Dill, Russ, linux-omap@vger.kernel.org
Hi Tomi,
On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
> On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
> > The revision check fails for the beaglebone; Add new revision ID.
> >
> > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> > ---
> > drivers/video/da8xx-fb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> > index 80665f6..866d804 100644
> > --- a/drivers/video/da8xx-fb.c
> > +++ b/drivers/video/da8xx-fb.c
> > @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
> > lcd_revision = LCD_VERSION_1;
> > break;
> > case 0x4F200800:
> > + case 0x4F201000:
>
> Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
> with to one read(0x4F200800) on emulator platform.
>
> Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>
>
This patch is necessary for am335x FB, I could not see in your for-next branch,
could you please consider this patch for 3.8 merge window. There are no pending
review comments on this.
Thanks,
Prakash
> > lcd_revision = LCD_VERSION_2;
> > break;
> > default:
> > --
> > 1.7.12
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] da8xx: Fix revision check on the da8xx driver
2012-12-04 6:36 ` Manjunathappa, Prakash
@ 2012-12-04 9:18 ` Tomi Valkeinen
0 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2012-12-04 9:18 UTC (permalink / raw)
To: Manjunathappa, Prakash
Cc: Pantelis Antoniou, Florian Tobias Schandinat,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Koen Kooi, Porter, Matt, Dill, Russ, linux-omap@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
On 2012-12-04 08:36, Manjunathappa, Prakash wrote:
> Hi Tomi,
>
> On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
>> On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
>>> The revision check fails for the beaglebone; Add new revision ID.
>>>
>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> ---
>>> drivers/video/da8xx-fb.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
>>> index 80665f6..866d804 100644
>>> --- a/drivers/video/da8xx-fb.c
>>> +++ b/drivers/video/da8xx-fb.c
>>> @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
>>> lcd_revision = LCD_VERSION_1;
>>> break;
>>> case 0x4F200800:
>>> + case 0x4F201000:
>>
>> Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
>> with to one read(0x4F200800) on emulator platform.
>>
>> Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>
>>
>
> This patch is necessary for am335x FB, I could not see in your for-next branch,
I have only applied the patches that have been sent to me.
> could you please consider this patch for 3.8 merge window. There are no pending
> review comments on this.
Applied.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-04 9:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-30 18:14 [PATCH] da8xx: Fix revision check on the da8xx driver Pantelis Antoniou
2012-10-31 3:51 ` Manjunathappa, Prakash
2012-12-04 6:36 ` Manjunathappa, Prakash
2012-12-04 9:18 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).