From: Vaibhav Hiremath <hvaibhav@ti.com>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>
Cc: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"Porter, Matt" <mporter@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"FlorianSchandinat@gmx.de" <FlorianSchandinat@gmx.de>,
Koen Kooi <koen@dominion.thruhere.net>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dill, Russ" <russ.dill@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] da8xx: Allow use by am33xx based devices
Date: Mon, 10 Dec 2012 09:14:06 +0000 [thread overview]
Message-ID: <50C5A50E.4070602@ti.com> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3EA1452B@DBDE01.ent.ti.com>
On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote:
> Hi Tomi,
>
> On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
>> Hi,
>>
>> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
>>> This driver can be used for AM33xx devices, like the popular beaglebone.
>>>
>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> ---
>>> drivers/video/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>>> index 9791d10..e7868d8 100644
>>> --- a/drivers/video/Kconfig
>>> +++ b/drivers/video/Kconfig
>>> @@ -2202,7 +2202,7 @@ config FB_SH7760
>>>
>>> config FB_DA8XX
>>> tristate "DA8xx/OMAP-L1xx Framebuffer support"
>>> - depends on FB && ARCH_DAVINCI_DA8XX
>>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
>>
>> Agreed this is present on da8xx and am33xx, but moving forward for
>> supporting DT, we should be avoiding these dependencies. So instead
>> change this to remove machine dependencies.
>>
>
> I could be wrong here, having dependency on platform seems to be right.
> Otherwise may lead to build errors for other platforms.
No, it should not result in to build error unless driver uses some
platform specific api's.
Thanks,
Vaibhav
> Please ignore my
> comments and accept this patch.
>
> Thanks,
> Prakash
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
>
next prev parent reply other threads:[~2012-12-10 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:18 [PATCH] da8xx: Allow use by am33xx based devices Pantelis Antoniou
2012-10-31 5:23 ` Manjunathappa, Prakash
2012-12-06 8:08 ` Manjunathappa, Prakash
2012-12-10 9:14 ` Vaibhav Hiremath [this message]
2012-12-12 7:20 ` Manjunathappa, Prakash
2012-12-12 8:00 ` Hiremath, Vaibhav
2013-01-07 12:03 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C5A50E.4070602@ti.com \
--to=hvaibhav@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
--cc=prakash.pm@ti.com \
--cc=russ.dill@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox