From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Date: Sat, 05 Jan 2013 12:06:59 +0000 Subject: Re: [PATCH] fb: Rework locking to fix lock ordering on takeover Message-Id: <50E81763.1070501@ahsoftware.de> List-Id: References: <20121116192606.11799.35711.stgit@localhost.localdomain> <20121121125310.00625f55@pyramind.ukuu.org.uk> <20121227045301.GB17472@x1.alien8.de> <20121228115022.GA28009@S2101-09.ap.freescale.net> <20121228124026.GB12918@x1.alien8.de> <50E6D01D.6040304@ahsoftware.de> <20130104132557.70e0c527@pyramind.ukuu.org.uk> <50E6DAC9.802@ahsoftware.de> <50E81166.6050605@ahsoftware.de> <20130105120729.7677c333@pyramind.ukuu.org.uk> In-Reply-To: <20130105120729.7677c333@pyramind.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Cox Cc: Borislav Petkov , Shawn Guo , Sasha Levin , Cong Wang , Josh Boyer , LKML , Florian Tobias Schandinat , Linus Torvalds , linux-fbdev@vger.kernel.org, Bernie Thompson , Steve Glendinning , Dave Airlie Am 05.01.2013 13:07, schrieb Alan Cox: >> So to add such an "I am crap" flag my idea would be to add an >> .fb_handle_damage to struct fb_ops and then call that (if exists) >> whenever something was changed. > > I was thinking much higher level - ie at the printk kind of level > >> My patch (for udlfb) follows as an reply to this message. If that patch >> is ok, it should be applied to smscufx too (I would make it). In regard >> to udl I don't know, I haven't had a deeper look at it nor used it up to >> now. > > Looks pretty clean as a solution to me. Thanks and sorry for the two empty lines in the patch. I swear I had a look at the patch before sending it out, but haven't seen them. So should I make the same patch for smscufx and while beeing there, send out at v2 without those 2 empty lines? Regards, Alexander