From: Timur Tabi <timur@tabi.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling
Date: Sat, 19 Jan 2013 13:51:35 +0000 [thread overview]
Message-ID: <50FAA4E7.6070808@tabi.org> (raw)
In-Reply-To: <1358589550-3246-1-git-send-email-agust@denx.de>
Anatolij Gustschin wrote:
> Disabling the interrupts in fsl_diu_release() must happen only if all
> other AOIs are closed. Otherwise closing an overlay plane will disable
> the interrupts even if the primary frame buffer plane is opened. Add
> an appropriate check in the release function.
I thought the release function is only called when the driver is unloaded.
Wouldn't the framebuffers all already be closed by then?
> +static inline void fsl_diu_enable_interrupts(struct fsl_diu_data *data)
> +{
> + u32 int_mask = INT_UNDRUN; /* enable underrun detection */
> +
> + if (IS_ENABLED(CONFIG_NOT_COHERENT_CACHE))
> + int_mask |= INT_VSYNC; /* enable vertical sync */
Why did you turn this into a run-time check?
--
Timur Tabi
next prev parent reply other threads:[~2013-01-19 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 9:59 [PATCH v2 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling Anatolij Gustschin
2013-01-19 13:51 ` Timur Tabi [this message]
2013-01-19 14:19 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FAA4E7.6070808@tabi.org \
--to=timur@tabi.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).