From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 12 Nov 2012 11:46:46 +0000 Subject: Re: [PATCH v7 5/8] fbmon: add videomode helpers Message-Id: <5107065.d4AsRkFIOU@avalon> List-Id: References: <1351675689-26814-1-git-send-email-s.trumtrar@pengutronix.de> <20121109193133.GD3660@pengutronix.de> In-Reply-To: <20121109193133.GD3660@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steffen Trumtrar Cc: "Manjunathappa, Prakash" , "linux-fbdev@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "dri-devel@lists.freedesktop.org" , "Valkeinen, Tomi" , "kernel@pengutronix.de" , Guennady Liakhovetski , "linux-media@vger.kernel.org" Hi Steffen, On Friday 09 November 2012 20:31:33 Steffen Trumtrar wrote: > On Fri, Nov 09, 2012 at 04:54:16PM +0000, Manjunathappa, Prakash wrote: > > On Fri, Nov 09, 2012 at 02:55:45, Steffen Trumtrar wrote: > > > On Wed, Oct 31, 2012 at 03:30:03PM +0000, Manjunathappa, Prakash wrote: > > > > On Wed, Oct 31, 2012 at 14:58:05, Steffen Trumtrar wrote: > > > > > +#if IS_ENABLED(CONFIG_VIDEOMODE) > > > > > +int videomode_to_fb_videomode(struct videomode *vm, struct > > > > > fb_videomode *fbmode) +{ > > > > > + fbmode->xres = vm->hactive; > > > > > + fbmode->left_margin = vm->hback_porch; > > > > > + fbmode->right_margin = vm->hfront_porch; > > > > > + fbmode->hsync_len = vm->hsync_len; > > > > > + > > > > > + fbmode->yres = vm->vactive; > > > > > + fbmode->upper_margin = vm->vback_porch; > > > > > + fbmode->lower_margin = vm->vfront_porch; > > > > > + fbmode->vsync_len = vm->vsync_len; > > > > > + > > > > > + fbmode->pixclock = KHZ2PICOS(vm->pixelclock / 1000); > > > > > + > > > > > + fbmode->sync = 0; > > > > > + fbmode->vmode = 0; > > > > > + if (vm->hah) > > > > > + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > > > > > + if (vm->vah) > > > > > + fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > > > > > + if (vm->interlaced) > > > > > + fbmode->vmode |= FB_VMODE_INTERLACED; > > > > > + if (vm->doublescan) > > > > > + fbmode->vmode |= FB_VMODE_DOUBLE; > > > > > + > > > > > > > > "pixelclk-inverted" property of the panel is not percolated > > > > fb_videomode. > > > > Please let me know if I am missing something. > > > > > > The next version is almost finished. Only thing I'm missing is this. > > > And I actually do not know which flag would represent an inverted > > > pixelclock in fb_videomode. Does anybody have any idea what I have to > > > do here?> > > > > if (vm->pixelclk_pol) > > > > > > fbmode->sync = ??? > > > > > > That's as far as I have come and I don't see a flag that seems right. > > > Is this even a valid property of fb_videomode? > > > > Thanks for considering it, I see IMX addresses it as proprietary FB_SYNC_ > > flag. FB_SYNC_CLK_INVERT: arch/arm/plat-mxc/include/mach/mx3fb.h > > No problem. So, it seems this flag has to be set in some imx-specific > videomode_to_fb_videomode function. It is included in the > struct videomode, so that should be no problem. But it will not be > part of this series. A possible solution would be to standardize the FB_SYNC_CLK_INVERT flag in fbdev, but that's in my opinion out of scope of this patch series. iMX3 developers, feel free to send patches :-) -- Regards, Laurent Pinchart