From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Date: Thu, 31 Jan 2013 12:38:18 +0000 Subject: Re: [PATCH 2/4] pwm_backlight: Validate dft_brightness in main probe function Message-Id: <510A65BA.6090208@ti.com> List-Id: References: <1358861996-27194-1-git-send-email-peter.ujfalusi@ti.com> <1358861996-27194-3-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1358861996-27194-3-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Richard Purdie Cc: Grant Likely , Rob Landley , Thierry Reding , Florian Tobias Schandinat , Andrew Morton , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Hi Thierry, On 01/22/2013 02:39 PM, Peter Ujfalusi wrote: > Move the dft_brightness validity check from the DT parsing function to the > main probe. In this way we can validate it in case we are booting with or > without DT. Based on the discussion the rest of the series is going to be dropped, but what about this single patch? I think it is still addresses a valid issue, which is that in non DT boot we do not check if the dft_brightness is within valid range. I can resend this patch alone since it is not going to apply on mainline as= it is. --=20 P=E9ter >=20 > Signed-off-by: Peter Ujfalusi > --- > drivers/video/backlight/pwm_bl.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/p= wm_bl.c > index f0d6854..2a81c24 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -135,12 +135,6 @@ static int pwm_backlight_parse_dt(struct device *dev, > if (ret < 0) > return ret; > =20 > - if (value >=3D data->max_brightness) { > - dev_warn(dev, "invalid default brightness level: %u, using %u\n", > - value, data->max_brightness - 1); > - value =3D data->max_brightness - 1; > - } > - > data->dft_brightness =3D value; > } > =20 > @@ -249,6 +243,12 @@ static int pwm_backlight_probe(struct platform_devic= e *pdev) > goto err_alloc; > } > =20 > + if (data->dft_brightness > data->max_brightness) { > + dev_warn(&pdev->dev, > + "invalid default brightness level: %u, using %u\n", > + data->dft_brightness, data->max_brightness); > + data->dft_brightness =3D data->max_brightness; > + } > bl->props.brightness =3D data->dft_brightness; > backlight_update_status(bl); > =20 >=20