From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Mon, 11 Mar 2013 06:17:24 +0000 Subject: Re: [PATCH 18/20] OMAPDSS: DSI: delay dispc initialization Message-Id: <513D7424.1000609@ti.com> List-Id: References: <1362743515-10152-1-git-send-email-tomi.valkeinen@ti.com> <1362743515-10152-19-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: <1362743515-10152-19-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote: > We currently setup both DSI and DISPC related things when the DSI bus is > enabled. There's no need for DISPC related thing at that point, though, > but only later when the video output is enabled. > > To make it possible to use the DSI bus before DISPC overlay manager is > selected, this patch moves DSI's DISPC initialization to > dsi_enable_video_output(), from omapdss_dsi_display_enable(). We also > move the selection of DISPC's LCD clock to dsi_enable_video_output. > > This way there are no DISPC dependencies until the video output is > enabled. This is a good patch. I hope CDF also makes sure the Display controller and DSI bus are made more independent in this manner. One thing which we should eventually add is to ensure that omap_dsi_update() for command mode panels is called only after dsi_enable_video_output() is called. I think we manage this in our panel driver, but maybe some sort of check could help there. Archit