From: Timur Tabi <timur@tabi.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: fsl-diu-fb: optionally configure frame buffer depth in DT
Date: Wed, 13 Mar 2013 15:37:39 +0000 [thread overview]
Message-ID: <51409D43.4080902@tabi.org> (raw)
In-Reply-To: <1363188249-29341-1-git-send-email-agust@denx.de>
On 03/13/2013 10:24 AM, Anatolij Gustschin wrote:
> @@ -30,5 +31,6 @@ Example for MPC5121:
> reg = <0x2100 0x100>;
> interrupts = <64 0x8>;
> interrupt-parent = <&ipic>;
> + depth = <16>;
NACK.
Device trees are supposed to be used for describing the hardware, not
for software configuration. Besides, the driver already supports a
command-line parameter for the color depth. Your patch just overrides
that parameter (default_bpp) with a device tree property.
module_param_named(mode, fb_mode, charp, 0);
MODULE_PARM_DESC(mode,
"Specify resolution as \"<xres>x<yres>[-<bpp>][@<refresh>]\" ");
module_param_named(bpp, default_bpp, ulong, 0);
MODULE_PARM_DESC(bpp, "Specify bit-per-pixel if not specified in 'mode'");
module_param_named(monitor, monitor_string, charp, 0);
MODULE_PARM_DESC(monitor, "Specify the monitor port "
"(\"dvi\", \"lvds\", or \"dlvds\") if supported by the platform");
prev parent reply other threads:[~2013-03-13 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 15:24 [PATCH] fbdev: fsl-diu-fb: optionally configure frame buffer depth in DT Anatolij Gustschin
2013-03-13 15:37 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51409D43.4080902@tabi.org \
--to=timur@tabi.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox