From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Hennerich <michael.hennerich@analog.com>
Date: Mon, 25 Mar 2013 08:41:57 +0000
Subject: Re: [PATCH -next] backlight: adp8860: fix error return code in adp8860_led_probe()
Message-Id: <51500DD5.8060504@analog.com>
List-Id: <linux-fbdev.vger.kernel.org>
References: <CAPgLHd-wxGVKjMpWPDeKqWM+Va6dLnu_spwyb=QUybxjOo=AWA@mail.gmail.com>
In-Reply-To: <CAPgLHd-wxGVKjMpWPDeKqWM+Va6dLnu_spwyb=QUybxjOo=AWA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-fbdev@vger.kernel.org

On 03/22/2013 12:30 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>   drivers/video/backlight/adp8860_bl.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 6bb7f36..75b10f8 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -249,12 +249,14 @@ static int adp8860_led_probe(struct i2c_client *client)
>   		if (led_dat->id > 7 || led_dat->id < 1) {
>   			dev_err(&client->dev, "Invalid LED ID %d\n",
>   				led_dat->id);
> +			ret = -EINVAL;
>   			goto err;
>   		}
>   
>   		if (pdata->bl_led_assign & (1 << (led_dat->id - 1))) {
>   			dev_err(&client->dev, "LED %d used by Backlight\n",
>   				led_dat->id);
> +			ret = -EBUSY;
>   			goto err;
>   		}
>   
>
>
>


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif