From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 16/26] OMAPDSS: TFP410: convert to platform device
Date: Wed, 27 Mar 2013 11:29:15 +0000 [thread overview]
Message-ID: <5152D53B.9000509@ti.com> (raw)
In-Reply-To: <5152D49A.2090309@ti.com>
On Wednesday 27 March 2013 04:44 PM, Tomi Valkeinen wrote:
> On 2013-03-27 13:11, Archit Taneja wrote:
>> On Tuesday 26 March 2013 07:03 PM, Tomi Valkeinen wrote:
>>> Convert TFP410 driver from omap_dss_driver to a platform driver. The
>>> driver uses the new panel support from omapdss.
>>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>> ---
>>> drivers/video/omap2/displays/panel-tfp410.c | 205
>>> +++++++++++++++++----------
>>> 1 file changed, 128 insertions(+), 77 deletions(-)
>>>
>
>>> - ddata->i2c_adapter = adapter;
>>> + dssdev = &ddata->dssdev;
>>> + dssdev->driver = &tfp410_driver;
>>> + dssdev->panel.timings = tfp410_default_timings;
>>> + dssdev->name = ddata->name;
>>> + dssdev->phy.dpi.data_lines = ddata->data_lines;
>>> + dssdev->panel_dev = &pdev->dev;
>>
>> Some of the omap_dss_device fields populated here(like data_lines) are
>> not going to be used anywhere. Are you populating all of them just for
>> the sake of clarity, so that they can be removed in another series later
>> on? Or is there some other reason?
>
> Unfortunately the datalines are used in
> omapdss_default_get_recommended_bpp(). So there are some fields
> populated just to keep things working, and I expect that they are
> removed later.
Ah okay, missed that. I guess it will be easier to remove these later on
anyway.
Archit
next prev parent reply other threads:[~2013-03-27 11:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 13:33 [PATCH 00/26] DSS device model change Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 01/26] OMAPDSS: only probe pdata if there's one Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 02/26] OMAPDSS: add omap_dss_find_output() Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 03/26] OMAPDSS: add omap_dss_find_output_by_node() Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 04/26] OMAPDSS: fix dss_get_ctx_loss_count for DT Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 05/26] OMAPDSS: DPI: fix regulators Tomi Valkeinen
2013-03-27 9:57 ` Archit Taneja
2013-03-26 13:33 ` [PATCH 06/26] OMAPDSS: SDI: " Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 07/26] OMAPDSS: add panel list Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 08/26] OMAPDSS: use the panel list in omap_dss_get_next_device Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 09/26] OMAPDSS: don't use dss bus in suspend/resume Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 10/26] OMAPDSS: implement display sysfs without dss bus Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 11/26] OMAPDSS: Add panel_dev pointer to dssdev Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 12/26] OMAPDSS: DPI: new panel registration Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 13/26] OMAPDSS: DSI: " Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 14/26] OMAPDSS: HDMI: " Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 15/26] OMAPDSS: TFP410 platform_data changes Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 16/26] OMAPDSS: TFP410: convert to platform device Tomi Valkeinen
2013-03-27 11:23 ` Archit Taneja
2013-03-27 11:14 ` Tomi Valkeinen
2013-03-27 11:29 ` Archit Taneja [this message]
2013-03-26 13:33 ` [PATCH 17/26] OMAPDSS: generic-dpi-panel platform_data changes Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 18/26] OMAPDSS: panel-generic-dpi: convert to platform device Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 19/26] OMAPDSS: HDMI: " Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 20/26] OMAPDSS: Taal platform_data changes Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 21/26] OMAPDSS: Taal: convert to platform device Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 22/26] ARM: OMAP: Panda: use new TFP410 platform driver Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 23/26] ARM: OMAP: Panda & SDP: use new HDMI driver Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 24/26] ARM: OMAP: 4430SDP: use new Taal driver Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 25/26] ARM: OMAP: Overo: use new TFP410 platform driver Tomi Valkeinen
2013-03-26 13:33 ` [PATCH 26/26] ARM: OMAP: Overo: use new generic-dpi-panel " Tomi Valkeinen
2013-03-26 17:10 ` [PATCH 00/26] DSS device model change Tony Lindgren
2013-03-27 6:13 ` Tomi Valkeinen
2013-03-27 20:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5152D53B.9000509@ti.com \
--to=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).