From mboxrd@z Thu Jan 1 00:00:00 1970 From: Donghwa Lee Date: Wed, 27 Mar 2013 23:52:50 +0000 Subject: Re: [PATCH] video: exynos: Convert to devm_ioremap_resource() Message-Id: <51538652.7040005@samsung.com> List-Id: References: <1364416081-24113-1-git-send-email-epure.andrei@gmail.com> In-Reply-To: <1364416081-24113-1-git-send-email-epure.andrei@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrei Epure Cc: inki.dae@samsung.com, kyungmin.park@samsung.com, FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hi, Please refer to the following link. http://marc.info/?l=linux-fbdev&m5963121130437&w=2 Best regard, Donghwa Lee On Thu, Mar 28, 2013 at 05:28, Andrei Epure wrote: > The new devm_ioremap_resource() provides its own error messages. > Patch found using coccinelle. > > Signed-off-by: Andrei Epure > --- > drivers/video/exynos/exynos_mipi_dsi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c > index fac7df6..dd5e5e9 100644 > --- a/drivers/video/exynos/exynos_mipi_dsi.c > +++ b/drivers/video/exynos/exynos_mipi_dsi.c > @@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res); > - if (!dsim->reg_base) { > - dev_err(&pdev->dev, "failed to remap io region\n"); > - ret = -ENOMEM; > + dsim->reg_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(dsim->reg_base)) { > + ret = PTR_ERR(dsim->reg_base); > goto error; > } >