* [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo @ 2013-03-29 1:40 Jingoo Han 2013-03-29 8:41 ` Steffen Trumtrar 2013-04-05 6:57 ` Tomi Valkeinen 0 siblings, 2 replies; 4+ messages in thread From: Jingoo Han @ 2013-03-29 1:40 UTC (permalink / raw) To: akpm Cc: linux-kernel, linux-fbdev, tomi.valkeinen, FlorianSchandinat, s.trumtrar, plagnioj, jg1.han VkVTQV9ETVRfVlNZTkNfSElHSCBzaG91bGQgYmUgdXNlZCBpbnN0ZWFkIG9mIFZFU0FfRE1UX0hT WU5DX0hJR0gsDQpiZWNhdXNlIEZCX1NZTkNfVkVSVF9ISUdIX0FDVCBpcyByZWxhdGVkIHRvIHZz eW5jLCBub3QgdG8gaHN5bmMuDQoNClNpZ25lZC1vZmYtYnk6IEppbmdvbyBIYW4gPGpnMS5oYW5A c2Ftc3VuZy5jb20+DQpDYzogU3RlZmZlbiBUcnVtdHJhciA8cy50cnVtdHJhckBwZW5ndXRyb25p eC5kZT4NCkNjOiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPg0KLS0tDQog ZHJpdmVycy92aWRlby9mYm1vbi5jIHwgICAgMiArLQ0KIDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9m Ym1vbi5jIGIvZHJpdmVycy92aWRlby9mYm1vbi5jDQppbmRleCA5NGFkMGY3Li43ZjY3MDk5IDEw MDY0NA0KLS0tIGEvZHJpdmVycy92aWRlby9mYm1vbi5jDQorKysgYi9kcml2ZXJzL3ZpZGVvL2Zi bW9uLmMNCkBAIC0xNDAwLDcgKzE0MDAsNyBAQCBpbnQgZmJfdmlkZW9tb2RlX2Zyb21fdmlkZW9t b2RlKGNvbnN0IHN0cnVjdCB2aWRlb21vZGUgKnZtLA0KIAlmYm1vZGUtPnZtb2RlID0gMDsNCiAJ aWYgKHZtLT5kbXRfZmxhZ3MgJiBWRVNBX0RNVF9IU1lOQ19ISUdIKQ0KIAkJZmJtb2RlLT5zeW5j IHw9IEZCX1NZTkNfSE9SX0hJR0hfQUNUOw0KLQlpZiAodm0tPmRtdF9mbGFncyAmIFZFU0FfRE1U X0hTWU5DX0hJR0gpDQorCWlmICh2bS0+ZG10X2ZsYWdzICYgVkVTQV9ETVRfVlNZTkNfSElHSCkN CiAJCWZibW9kZS0+c3luYyB8PSBGQl9TWU5DX1ZFUlRfSElHSF9BQ1Q7DQogCWlmICh2bS0+ZGF0 YV9mbGFncyAmIERJU1BMQVlfRkxBR1NfSU5URVJMQUNFRCkNCiAJCWZibW9kZS0+dm1vZGUgfD0g RkJfVk1PREVfSU5URVJMQUNFRDsNCi0tIA0KMS43LjIuNQ0K ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo 2013-03-29 1:40 [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo Jingoo Han @ 2013-03-29 8:41 ` Steffen Trumtrar 2013-04-05 6:57 ` Tomi Valkeinen 1 sibling, 0 replies; 4+ messages in thread From: Steffen Trumtrar @ 2013-03-29 8:41 UTC (permalink / raw) To: Jingoo Han Cc: akpm, linux-kernel, linux-fbdev, tomi.valkeinen, FlorianSchandinat, plagnioj On Fri, Mar 29, 2013 at 01:40:52AM +0000, Jingoo Han wrote: > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH, > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/fbmon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > index 94ad0f7..7f67099 100644 > --- a/drivers/video/fbmon.c > +++ b/drivers/video/fbmon.c > @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm, > fbmode->vmode = 0; > if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > - if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > + if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH) > fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) > fbmode->vmode |= FB_VMODE_INTERLACED; > -- > 1.7.2.5 Hi, I already implied this on the original mail, but to be clear: Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Thanks, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo 2013-03-29 1:40 [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo Jingoo Han 2013-03-29 8:41 ` Steffen Trumtrar @ 2013-04-05 6:57 ` Tomi Valkeinen 2013-04-05 8:02 ` Jingoo Han 1 sibling, 1 reply; 4+ messages in thread From: Tomi Valkeinen @ 2013-04-05 6:57 UTC (permalink / raw) To: jg1.han Cc: akpm, linux-kernel, linux-fbdev, FlorianSchandinat, s.trumtrar, plagnioj [-- Attachment #1: Type: text/plain, Size: 1077 bytes --] Hi, On 2013-03-29 03:40, Jingoo Han wrote: > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH, > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/fbmon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > index 94ad0f7..7f67099 100644 > --- a/drivers/video/fbmon.c > +++ b/drivers/video/fbmon.c > @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm, > fbmode->vmode = 0; > if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > - if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > + if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH) > fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) > fbmode->vmode |= FB_VMODE_INTERLACED; I'll apply this to fbdev fixes. Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 899 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo 2013-04-05 6:57 ` Tomi Valkeinen @ 2013-04-05 8:02 ` Jingoo Han 0 siblings, 0 replies; 4+ messages in thread From: Jingoo Han @ 2013-04-05 8:02 UTC (permalink / raw) To: 'Tomi Valkeinen' Cc: akpm, linux-kernel, linux-fbdev, FlorianSchandinat, s.trumtrar, plagnioj, 'Jingoo Han' On Friday, April 05, 2013 3:57 PM, Tomi Valkeinen wrote: > > Hi, > > On 2013-03-29 03:40, Jingoo Han wrote: > > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH, > > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > > --- > > drivers/video/fbmon.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > > index 94ad0f7..7f67099 100644 > > --- a/drivers/video/fbmon.c > > +++ b/drivers/video/fbmon.c > > @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm, > > fbmode->vmode = 0; > > if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > > fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > > - if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > > + if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH) > > fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > > if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) > > fbmode->vmode |= FB_VMODE_INTERLACED; > > I'll apply this to fbdev fixes. Oh, thank you. :) Best regards, Jingoo Han > > Tomi > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-05 8:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-29 1:40 [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo Jingoo Han 2013-03-29 8:41 ` Steffen Trumtrar 2013-04-05 6:57 ` Tomi Valkeinen 2013-04-05 8:02 ` Jingoo Han
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).