From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] omapdss: use devm_clk_get()
Date: Wed, 10 Apr 2013 09:32:06 +0000 [thread overview]
Message-ID: <51653196.6050304@ti.com> (raw)
In-Reply-To: <516530B1.80203@ti.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On 2013-04-10 12:28, Archit Taneja wrote:
> Ah ok, I remember it now. One of the DPLL's divider's output is DSS_FCK.
> We get the parent's rate and iterate through all the possible hsdivider
> values to get the closest pixel clock. We don't/can't change
> dpll4_m4_clk as such, we just need to know it's rate for our calculations.
>
> So yes, we need dpll4_m4_clk, we just need to rename it to a better
> thing. Like dss_clk_parent.
Right. And the field name in struct dss_features, "clk_name" is rather
vague.
At some point we should fix the omap clk framework so that we can set
the dss fck directly. Presuming there's no good reason to have it as it
is now.
I'll apply the patch as it is now.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2013-04-10 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 8:56 [PATCH] omapdss: use devm_clk_get() Archit Taneja
2013-04-10 8:13 ` Tomi Valkeinen
2013-04-10 8:49 ` Archit Taneja
2013-04-10 9:19 ` Tomi Valkeinen
2013-04-10 9:40 ` Archit Taneja
2013-04-10 9:32 ` Tomi Valkeinen [this message]
2013-04-10 9:41 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51653196.6050304@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).