* Re: linux-next: Tree for Jun 3 (fonts.c & vivi) [not found] <20130603163717.a6f78476e57d92fadd6f6a23@canb.auug.org.au> @ 2013-06-03 20:34 ` Randy Dunlap 2013-06-03 20:54 ` Geert Uytterhoeven 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2013-06-03 20:34 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linux-next, linux-kernel, linux-media, linux-fbdev On 06/02/13 23:37, Stephen Rothwell wrote: > Hi all, > > Changes since 20130531: > on x86_64: warning: (VIDEO_VIVI && USB_SISUSBVGA && SOLO6X10) selects FONT_SUPPORT which has unmet direct dependencies (HAS_IOMEM && VT) warning: (VIDEO_VIVI && FB_VGA16 && FB_S3 && FB_VT8623 && FB_ARK && USB_SISUSBVGA_CON && SOLO6X10) selects FONT_8x16 which has unmet direct dependencies (HAS_IOMEM && VT && FONT_SUPPORT) drivers/built-in.o: In function `vivi_init': vivi.c:(.init.text+0x1a3da): undefined reference to `find_font' when CONFIG_VT is not enabled. Just make CONFIG_VIDEO_VIVI depend on VT ? -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 3 (fonts.c & vivi) 2013-06-03 20:34 ` linux-next: Tree for Jun 3 (fonts.c & vivi) Randy Dunlap @ 2013-06-03 20:54 ` Geert Uytterhoeven 2013-06-03 21:06 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2013-06-03 20:54 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Linux-Next, linux-kernel@vger.kernel.org, linux-media, Linux Fbdev development list On Mon, Jun 3, 2013 at 10:34 PM, Randy Dunlap <rdunlap@infradead.org> wrote: > On 06/02/13 23:37, Stephen Rothwell wrote: >> Changes since 20130531: > on x86_64: > > warning: (VIDEO_VIVI && USB_SISUSBVGA && SOLO6X10) selects FONT_SUPPORT which has unmet direct dependencies (HAS_IOMEM && VT) > warning: (VIDEO_VIVI && FB_VGA16 && FB_S3 && FB_VT8623 && FB_ARK && USB_SISUSBVGA_CON && SOLO6X10) selects FONT_8x16 which has unmet direct dependencies (HAS_IOMEM && VT && FONT_SUPPORT) I knew about thet warning. But I thought it was harmless, as none of the font code really depends on console support... > drivers/built-in.o: In function `vivi_init': > vivi.c:(.init.text+0x1a3da): undefined reference to `find_font' > > when CONFIG_VT is not enabled. ... but I missed that drivers/video/console is not used if CONFIG_VT=y. Sorry for that. > Just make CONFIG_VIDEO_VIVI depend on VT ? Does this (whitespace-damaged copy-and-paste) help? --- a/drivers/video/Makefile +++ b/drivers/video/Makefile @@ -12,7 +12,7 @@ fb-y := fbmem.o fbmon.o fbcmap.o modedb.o fbcvt.o fb-objs := $(fb-y) -obj-$(CONFIG_VT) += console/ +obj-y += console/ obj-$(CONFIG_LOGO) += logo/ obj-y += backlight/ It shouldn't make a difference if nothing inside drivers/video/console is enabled, as all objects in drivers/video/console/Makefile are conditional. BTW, my plan was to move the font code to lib/font, but I haven't done that yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 3 (fonts.c & vivi) 2013-06-03 20:54 ` Geert Uytterhoeven @ 2013-06-03 21:06 ` Randy Dunlap 2013-06-04 6:50 ` Geert Uytterhoeven 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2013-06-03 21:06 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Stephen Rothwell, Linux-Next, linux-kernel@vger.kernel.org, linux-media, Linux Fbdev development list On 06/03/13 13:54, Geert Uytterhoeven wrote: > On Mon, Jun 3, 2013 at 10:34 PM, Randy Dunlap <rdunlap@infradead.org> wrote: >> On 06/02/13 23:37, Stephen Rothwell wrote: >>> Changes since 20130531: >> on x86_64: >> >> warning: (VIDEO_VIVI && USB_SISUSBVGA && SOLO6X10) selects FONT_SUPPORT which has unmet direct dependencies (HAS_IOMEM && VT) >> warning: (VIDEO_VIVI && FB_VGA16 && FB_S3 && FB_VT8623 && FB_ARK && USB_SISUSBVGA_CON && SOLO6X10) selects FONT_8x16 which has unmet direct dependencies (HAS_IOMEM && VT && FONT_SUPPORT) > > I knew about thet warning. But I thought it was harmless, as none of the font > code really depends on console support... > >> drivers/built-in.o: In function `vivi_init': >> vivi.c:(.init.text+0x1a3da): undefined reference to `find_font' >> >> when CONFIG_VT is not enabled. > > ... but I missed that drivers/video/console is not used if CONFIG_VT=y. > Sorry for that. > >> Just make CONFIG_VIDEO_VIVI depend on VT ? > > Does this (whitespace-damaged copy-and-paste) help? Yes, that works. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> > --- a/drivers/video/Makefile > +++ b/drivers/video/Makefile > @@ -12,7 +12,7 @@ fb-y := fbmem.o fbmon.o fbcmap.o > modedb.o fbcvt.o > fb-objs := $(fb-y) > > -obj-$(CONFIG_VT) += console/ > +obj-y += console/ > obj-$(CONFIG_LOGO) += logo/ > obj-y += backlight/ > > It shouldn't make a difference if nothing inside drivers/video/console > is enabled, > as all objects in drivers/video/console/Makefile are conditional. > > BTW, my plan was to move the font code to lib/font, but I haven't done that yet. -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 3 (fonts.c & vivi) 2013-06-03 21:06 ` Randy Dunlap @ 2013-06-04 6:50 ` Geert Uytterhoeven 0 siblings, 0 replies; 4+ messages in thread From: Geert Uytterhoeven @ 2013-06-04 6:50 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Linux-Next, linux-kernel@vger.kernel.org, linux-media, Linux Fbdev development list On Mon, Jun 3, 2013 at 11:06 PM, Randy Dunlap <rdunlap@infradead.org> wrote: > On 06/03/13 13:54, Geert Uytterhoeven wrote: >> On Mon, Jun 3, 2013 at 10:34 PM, Randy Dunlap <rdunlap@infradead.org> wrote: >>> On 06/02/13 23:37, Stephen Rothwell wrote: >>>> Changes since 20130531: >>> on x86_64: >>> >>> warning: (VIDEO_VIVI && USB_SISUSBVGA && SOLO6X10) selects FONT_SUPPORT which has unmet direct dependencies (HAS_IOMEM && VT) >>> warning: (VIDEO_VIVI && FB_VGA16 && FB_S3 && FB_VT8623 && FB_ARK && USB_SISUSBVGA_CON && SOLO6X10) selects FONT_8x16 which has unmet direct dependencies (HAS_IOMEM && VT && FONT_SUPPORT) >> >> I knew about thet warning. But I thought it was harmless, as none of the font >> code really depends on console support... >> >>> drivers/built-in.o: In function `vivi_init': >>> vivi.c:(.init.text+0x1a3da): undefined reference to `find_font' >>> >>> when CONFIG_VT is not enabled. >> >> ... but I missed that drivers/video/console is not used if CONFIG_VT=y. >> Sorry for that. >> >>> Just make CONFIG_VIDEO_VIVI depend on VT ? >> >> Does this (whitespace-damaged copy-and-paste) help? > > Yes, that works. Thanks. > > Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks, I'll fold this into the original commit, which is destined for v3.10. >> --- a/drivers/video/Makefile >> +++ b/drivers/video/Makefile >> @@ -12,7 +12,7 @@ fb-y := fbmem.o fbmon.o fbcmap.o >> modedb.o fbcvt.o >> fb-objs := $(fb-y) >> >> -obj-$(CONFIG_VT) += console/ >> +obj-y += console/ >> obj-$(CONFIG_LOGO) += logo/ >> obj-y += backlight/ >> >> It shouldn't make a difference if nothing inside drivers/video/console >> is enabled, >> as all objects in drivers/video/console/Makefile are conditional. >> >> BTW, my plan was to move the font code to lib/font, but I haven't done that yet. I'l try to do that for v3.11. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-04 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130603163717.a6f78476e57d92fadd6f6a23@canb.auug.org.au>
2013-06-03 20:34 ` linux-next: Tree for Jun 3 (fonts.c & vivi) Randy Dunlap
2013-06-03 20:54 ` Geert Uytterhoeven
2013-06-03 21:06 ` Randy Dunlap
2013-06-04 6:50 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).