From: Archit Taneja <archit@ti.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: axel.lin@gmail.com, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, "Valkeinen,
Tomi" <tomi.valkeinen@ti.com>
Subject: Re: [PATCH] OMAPDSS: Remove kfree for memory allocated with devm_kzalloc
Date: Thu, 06 Jun 2013 07:22:01 +0000 [thread overview]
Message-ID: <51B035C9.1070506@ti.com> (raw)
In-Reply-To: <1370453396-18043-1-git-send-email-emilgoode@gmail.com>
Hi,
On Wednesday 05 June 2013 10:59 PM, Emil Goode wrote:
> It's not necessary to free memory allocated with devm_kzalloc
> in a remove function and using kfree leads to a double free.
Looks fine to me. Tomi, could you take this for 3.11?
Archit
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
> drivers/video/omap2/displays/panel-picodlp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-picodlp.c b/drivers/video/omap2/displays/panel-picodlp.c
> index 62f2db0..859e111 100644
> --- a/drivers/video/omap2/displays/panel-picodlp.c
> +++ b/drivers/video/omap2/displays/panel-picodlp.c
> @@ -469,8 +469,6 @@ static void picodlp_panel_remove(struct omap_dss_device *dssdev)
> i2c_unregister_device(picod->picodlp_i2c_client);
> dev_set_drvdata(&dssdev->dev, NULL);
> dev_dbg(&dssdev->dev, "removing picodlp panel\n");
> -
> - kfree(picod);
> }
>
> static int picodlp_panel_enable(struct omap_dss_device *dssdev)
>
prev parent reply other threads:[~2013-06-06 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 17:29 [PATCH] OMAPDSS: Remove kfree for memory allocated with devm_kzalloc Emil Goode
2013-06-06 7:22 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B035C9.1070506@ti.com \
--to=archit@ti.com \
--cc=axel.lin@gmail.com \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).