From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Thu, 06 Jun 2013 07:22:01 +0000 Subject: Re: [PATCH] OMAPDSS: Remove kfree for memory allocated with devm_kzalloc Message-Id: <51B035C9.1070506@ti.com> List-Id: References: <1370453396-18043-1-git-send-email-emilgoode@gmail.com> In-Reply-To: <1370453396-18043-1-git-send-email-emilgoode@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Emil Goode Cc: axel.lin@gmail.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, "Valkeinen, Tomi" Hi, On Wednesday 05 June 2013 10:59 PM, Emil Goode wrote: > It's not necessary to free memory allocated with devm_kzalloc > in a remove function and using kfree leads to a double free. Looks fine to me. Tomi, could you take this for 3.11? Archit > > Signed-off-by: Emil Goode > --- > drivers/video/omap2/displays/panel-picodlp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/omap2/displays/panel-picodlp.c b/drivers/video/omap2/displays/panel-picodlp.c > index 62f2db0..859e111 100644 > --- a/drivers/video/omap2/displays/panel-picodlp.c > +++ b/drivers/video/omap2/displays/panel-picodlp.c > @@ -469,8 +469,6 @@ static void picodlp_panel_remove(struct omap_dss_device *dssdev) > i2c_unregister_device(picod->picodlp_i2c_client); > dev_set_drvdata(&dssdev->dev, NULL); > dev_dbg(&dssdev->dev, "removing picodlp panel\n"); > - > - kfree(picod); > } > > static int picodlp_panel_enable(struct omap_dss_device *dssdev) >