linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Courbot <acourbot@nvidia.com>
To: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Olof Johansson <olof@lixom.net>,
	"gnurou@gmail.com" <gnurou@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v2] simplefb: add support for a8b8g8r8 pixel format
Date: Fri, 07 Jun 2013 07:28:29 +0000	[thread overview]
Message-ID: <51B18B9D.1030901@nvidia.com> (raw)
In-Reply-To: <1370589753.21409.140661241005617.2A5614D3@webmail.messagingengine.com>

On 06/07/2013 04:22 PM, Alexander van Heukelum wrote:
>>   static struct simplefb_format simplefb_formats[] = {
>>   	{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
>> +	{ "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {31, 8} },
>
> Hi,
>
> 31? I assume in practice this doesn't influence anything, but I think it should have read 24.

Doh. Thanks for pointing it out.

Alex.


      reply	other threads:[~2013-06-07  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07  6:01 [PATCH v2] simplefb: add support for a8b8g8r8 pixel format Alexandre Courbot
2013-06-07  7:22 ` Alexander van Heukelum
2013-06-07  7:28   ` Alex Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B18B9D.1030901@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=heukelum@fastmail.fm \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=plagnioj@jcrosoft.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).