From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 15/32] OMAPDSS: DPI: cleanup pll & regulator init
Date: Fri, 07 Jun 2013 08:45:39 +0000 [thread overview]
Message-ID: <51B19DB3.3060106@ti.com> (raw)
In-Reply-To: <51B182F7.7050002@ti.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On 07/06/13 09:51, Archit Taneja wrote:
>> -static int dpi_init_display(struct omap_dss_device *dssdev)
>> -{
>> - struct platform_device *dsidev;
>> -
>> - DSSDBG("init_display\n");
>> -
>> - if (dss_has_feature(FEAT_DPI_USES_VDDS_DSI) &&
>> - dpi.vdds_dsi_reg == NULL) {
>> - struct regulator *vdds_dsi;
>> -
>> - vdds_dsi = dss_get_vdds_dsi();
>> - if (IS_ERR(vdds_dsi)) {
>> - vdds_dsi = regulator_get(&dpi.pdev->dev, "vdds_dsi");
>
> same comment about devm_ usage here, and the next few patches.
Yes, good point. And that allows us to get rid of the 'vdds_dsi_from_core'.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-06-07 8:45 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 9:34 [PATCH 00/32] OMAPDSS: dss-dev-model "base" (Part 1/2) Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 01/32] OMAPDSS: add pdata->default_display_name Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 02/32] OMAPDSS: only probe pdata if there's one Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 03/32] OMAPDSS: add omap_dss_find_output() Tomi Valkeinen
2013-05-30 11:07 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 11:40 ` Tomi Valkeinen
2013-05-30 15:40 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 16:54 ` Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 04/32] OMAPDSS: add omap_dss_find_output_by_node() Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 05/32] OMAPDSS: fix dss_get_ctx_loss_count for DT Tomi Valkeinen
2013-05-30 11:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 11:28 ` Tomi Valkeinen
2013-05-30 15:43 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 16:14 ` Tomi Valkeinen
2013-05-30 16:36 ` Kevin Hilman
2013-05-30 17:21 ` Tomi Valkeinen
2013-05-31 15:17 ` Grygorii Strashko
2013-05-31 19:31 ` Kevin Hilman
2013-05-30 9:34 ` [PATCH 06/32] OMAPDSS: DPI: fix regulators " Tomi Valkeinen
2013-05-30 11:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 11:35 ` Tomi Valkeinen
2013-05-30 13:05 ` Arnd Bergmann
2013-05-30 15:54 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-07 5:57 ` Archit Taneja
2013-05-30 9:34 ` [PATCH 07/32] OMAPDSS: SDI: " Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 08/32] OMAPDSS: clean up dss_[ovl|mgr]_get_device() Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 09/32] OMAPDSS: add helpers to get mgr or output from display Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 10/32] OMAPDSS: split overlay manager creation Tomi Valkeinen
2013-06-07 6:31 ` Archit Taneja
2013-06-07 9:53 ` Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 11/32] OMAPDRM: fix overlay manager handling Tomi Valkeinen
2013-06-07 6:33 ` Archit Taneja
2013-05-30 9:34 ` [PATCH 12/32] OMAPDSS: Implement display (dis)connect support Tomi Valkeinen
2013-06-07 6:58 ` Archit Taneja
2013-06-07 8:31 ` Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 13/32] OMAPDSS: CORE: use devm_regulator_get Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 14/32] OMAPDSS: DSI: cleanup regulator init Tomi Valkeinen
2013-06-07 6:50 ` Archit Taneja
2013-05-30 9:34 ` [PATCH 15/32] OMAPDSS: DPI: cleanup pll & " Tomi Valkeinen
2013-06-07 6:52 ` Archit Taneja
2013-06-07 8:45 ` Tomi Valkeinen [this message]
2013-05-30 9:34 ` [PATCH 16/32] OMAPDSS: HDMI: add hdmi_init_regulator Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 17/32] OMAPDSS: SDI: clean up regulator init Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 18/32] OMAPDSS: VENC: " Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 19/32] OMAPDSS: add videomode conversion support Tomi Valkeinen
2013-06-07 7:18 ` Archit Taneja
2013-06-07 8:35 ` Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 20/32] OMAPDSS: remove dssdev uses in trivial cases Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 21/32] OMAPDSS: add panel list Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 22/32] OMAPDSS: use the panel list in omap_dss_get_next_device Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 23/32] OMAPDSS: don't use dss bus in suspend/resume Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 24/32] OMAPDSS: implement display sysfs without dss bus Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 25/32] OMAPDSS: Add panel dev pointer to dssdev Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 26/32] OMAPDSS: remove omap_dss_start/stop_device() Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 27/32] OMAPDSS: combine omap_dss_output into omap_dss_device Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 28/32] OMAPDSS: omapdss.h: add owner field to omap_dss_device Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 29/32] OMAPDSS: add module_get/put to omap_dss_get/put_device() Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 30/32] OMAPDSS: add THIS_MODULE owner to DSS outputs Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 31/32] OMAPDSS: output: increase refcount in find_output funcs Tomi Valkeinen
2013-05-30 9:34 ` [PATCH 32/32] OMAPFB: use EPROBE_DEFER if default display is not present Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B19DB3.3060106@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).