From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Tue, 25 Jun 2013 12:06:02 +0000 Subject: Re: [PATCH 3/9] aty128fb: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM) Message-Id: <51C987AA.9070006@huawei.com> List-Id: References: <1371543307-14360-1-git-send-email-wangyijing@huawei.com> In-Reply-To: <1371543307-14360-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean-Christophe Plagniol-Villard Cc: Yijing Wang , Paul Mackerras , Tomi Valkeinen , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Ping.....? On 2013/6/18 16:15, Yijing Wang wrote: > Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() > in init path. So we can use pdev->pm_cap instead of using > pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. > > Signed-off-by: Yijing Wang > Cc: Paul Mackerras > Cc: Jean-Christophe Plagniol-Villard > Cc: Tomi Valkeinen > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aty/aty128fb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c > index 8c55011..a4dfe8c 100644 > --- a/drivers/video/aty/aty128fb.c > +++ b/drivers/video/aty/aty128fb.c > @@ -2016,7 +2016,7 @@ static int aty128_init(struct pci_dev *pdev, const struct pci_device_id *ent) > > aty128_init_engine(par); > > - par->pm_reg = pci_find_capability(pdev, PCI_CAP_ID_PM); > + par->pm_reg = pdev->pm_cap; > par->pdev = pdev; > par->asleep = 0; > par->lock_blank = 0; > -- Thanks! Yijing