From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 26 Jun 2013 20:39:18 +0000 Subject: Re: [RFC 1/6] fbdev: simplefb: add init through platform_data Message-Id: <51CB5176.5000404@wwwdotorg.org> List-Id: References: <1372112849-670-1-git-send-email-dh.herrmann@gmail.com> <1372112849-670-2-git-send-email-dh.herrmann@gmail.com> In-Reply-To: <1372112849-670-2-git-send-email-dh.herrmann@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Herrmann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Airlie , linux-fbdev@vger.kernel.org, Stephen Warren , Olof Johansson On 06/24/2013 04:27 PM, David Herrmann wrote: > If we create proper platform-devices in x86 boot-code, we can use simplefb > for VBE or EFI framebuffers, too. However, there is normally no OF support > so we introduce a platform_data object so x86 boot-code can pass the > paramaters via plain old platform-data. > > This also removes the OF dependency as it is not needed. The headers > provide proper dummies for the case OF is disabled. > > Furthermore, we move the FORMAT-definitions to the common platform header > so initialization code can use it to transform "struct screen_info" to > the right format-name. > diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h > +/* the framebuffer size and location is available as IORESOURCE_MEM */ > +struct simplefb_platform_data { > + u32 width; > + u32 height; > + u32 stride; > + char format[64]; > +}; Any reason not to make format: const char *format; You should be able to initialize that just as easily in platform code, either as static data or at runtime, I think.