* [PATCH v3] video: xilinxfb: Fix compilation warning
@ 2013-07-25 13:45 Michal Simek
2013-07-25 23:14 ` Jingoo Han
2013-07-26 7:33 ` Tomi Valkeinen
0 siblings, 2 replies; 5+ messages in thread
From: Michal Simek @ 2013-07-25 13:45 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Jingoo Han, Geert Uytterhoeven
Cc: Michal Simek, Tomi Valkeinen, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
regs_phys is phys_addr_t (u32 or u64).
Lets use %pa printk format specifier.
Fixes compilation warning introduced by:
video: xilinxfb: Use drvdata->regs_phys instead of physaddr
(sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v3:
- Fix commit message reported by Geert
Changes in v2:
- Use %pa instead of casting
ppc44x_defconfig
Fixes regressions in v3.11-rc2
---
drivers/video/xilinxfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index f3d4a69..6629b29 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c
@@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev,
if (drvdata->flags & BUS_ACCESS_FLAG) {
/* Put a banner in the log (for DEBUG) */
- dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys,
- drvdata->regs);
+ dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
+ &drvdata->regs_phys, drvdata->regs);
}
/* Put a banner in the log (for DEBUG) */
dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n",
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] video: xilinxfb: Fix compilation warning
2013-07-25 13:45 [PATCH v3] video: xilinxfb: Fix compilation warning Michal Simek
@ 2013-07-25 23:14 ` Jingoo Han
2013-07-26 7:33 ` Tomi Valkeinen
1 sibling, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-07-25 23:14 UTC (permalink / raw)
To: 'Michal Simek',
'Jean-Christophe Plagniol-Villard'
Cc: 'Michal Simek', 'Tomi Valkeinen', linux-fbdev,
linux-kernel, 'Geert Uytterhoeven', Jingoo Han
On Thursday, July 25, 2013 10:45 PM, Michal Simek wrote:
>
> regs_phys is phys_addr_t (u32 or u64).
> Lets use %pa printk format specifier.
>
> Fixes compilation warning introduced by:
> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> Changes in v3:
> - Fix commit message reported by Geert
>
> Changes in v2:
> - Use %pa instead of casting
>
> ppc44x_defconfig
> Fixes regressions in v3.11-rc2
>
> ---
> drivers/video/xilinxfb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
> index f3d4a69..6629b29 100644
> --- a/drivers/video/xilinxfb.c
> +++ b/drivers/video/xilinxfb.c
> @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev,
>
> if (drvdata->flags & BUS_ACCESS_FLAG) {
> /* Put a banner in the log (for DEBUG) */
> - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys,
> - drvdata->regs);
> + dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
> + &drvdata->regs_phys, drvdata->regs);
> }
> /* Put a banner in the log (for DEBUG) */
> dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n",
> --
> 1.8.2.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] video: xilinxfb: Fix compilation warning
2013-07-25 13:45 [PATCH v3] video: xilinxfb: Fix compilation warning Michal Simek
2013-07-25 23:14 ` Jingoo Han
@ 2013-07-26 7:33 ` Tomi Valkeinen
2013-07-26 7:35 ` Tomi Valkeinen
1 sibling, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 7:33 UTC (permalink / raw)
To: Michal Simek
Cc: Jean-Christophe Plagniol-Villard, Jingoo Han, Geert Uytterhoeven,
Michal Simek, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
On 25/07/13 16:45, Michal Simek wrote:
> regs_phys is phys_addr_t (u32 or u64).
> Lets use %pa printk format specifier.
>
> Fixes compilation warning introduced by:
> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> Changes in v3:
> - Fix commit message reported by Geert
>
> Changes in v2:
> - Use %pa instead of casting
>
> ppc44x_defconfig
> Fixes regressions in v3.11-rc2
>
> ---
> drivers/video/xilinxfb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
> index f3d4a69..6629b29 100644
> --- a/drivers/video/xilinxfb.c
> +++ b/drivers/video/xilinxfb.c
> @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev,
>
> if (drvdata->flags & BUS_ACCESS_FLAG) {
> /* Put a banner in the log (for DEBUG) */
> - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys,
> - drvdata->regs);
> + dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
> + &drvdata->regs_phys, drvdata->regs);
> }
> /* Put a banner in the log (for DEBUG) */
> dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n",
> --
> 1.8.2.3
>
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] video: xilinxfb: Fix compilation warning
2013-07-26 7:33 ` Tomi Valkeinen
@ 2013-07-26 7:35 ` Tomi Valkeinen
2013-07-26 8:27 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 7:35 UTC (permalink / raw)
To: Michal Simek
Cc: Jean-Christophe Plagniol-Villard, Jingoo Han, Geert Uytterhoeven,
Michal Simek, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On 26/07/13 10:33, Tomi Valkeinen wrote:
> On 25/07/13 16:45, Michal Simek wrote:
>> regs_phys is phys_addr_t (u32 or u64).
>> Lets use %pa printk format specifier.
>>
>> Fixes compilation warning introduced by:
>> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
>> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Thanks, I've applied this into my 3.12/fbdev branch.
Actually, let's put this into 3.11-fixes/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] video: xilinxfb: Fix compilation warning
2013-07-26 7:35 ` Tomi Valkeinen
@ 2013-07-26 8:27 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2013-07-26 8:27 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Michal Simek, Jean-Christophe Plagniol-Villard, Jingoo Han,
Geert Uytterhoeven, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 07/26/2013 09:35 AM, Tomi Valkeinen wrote:
> On 26/07/13 10:33, Tomi Valkeinen wrote:
>> On 25/07/13 16:45, Michal Simek wrote:
>>> regs_phys is phys_addr_t (u32 or u64).
>>> Lets use %pa printk format specifier.
>>>
>>> Fixes compilation warning introduced by:
>>> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
>>> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
>> Thanks, I've applied this into my 3.12/fbdev branch.
>
> Actually, let's put this into 3.11-fixes/fbdev branch.
>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-26 8:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-25 13:45 [PATCH v3] video: xilinxfb: Fix compilation warning Michal Simek
2013-07-25 23:14 ` Jingoo Han
2013-07-26 7:33 ` Tomi Valkeinen
2013-07-26 7:35 ` Tomi Valkeinen
2013-07-26 8:27 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).