* [PATCH] backlight: lp855x: set zero brightness at FBBLANK
@ 2013-07-02 12:15 Oskar Andero
2013-07-02 23:24 ` Kim, Milo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oskar Andero @ 2013-07-02 12:15 UTC (permalink / raw)
To: linux-kernel, linux-fbdev
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Radovan Lekanovic, Shingo Nakao, Milo Kim, Richard Purdie,
Oskar Andero
From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
Cc: Milo Kim <milo.kim@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);
- if (bl->props.state & BL_CORE_SUSPENDED)
+ if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl->props.brightness = 0;
if (lp->mode = PWM_BASED) {
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
2013-07-02 12:15 [PATCH] backlight: lp855x: set zero brightness at FBBLANK Oskar Andero
@ 2013-07-02 23:24 ` Kim, Milo
2013-07-03 1:52 ` Jingoo Han
2013-07-26 8:45 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Kim, Milo @ 2013-07-02 23:24 UTC (permalink / raw)
To: Oskar Andero, Shingo Nakao
Cc: Jean-Christophe Plagniol-Villard, Valkeinen, Tomi,
Radovan Lekanovic, Richard Purdie, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, akpm@linux-foundation.org
> From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
Acked-by: Milo Kim <milo.kim@ti.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode = PWM_BASED) {
> --
> 1.8.1.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
2013-07-02 12:15 [PATCH] backlight: lp855x: set zero brightness at FBBLANK Oskar Andero
2013-07-02 23:24 ` Kim, Milo
@ 2013-07-03 1:52 ` Jingoo Han
2013-07-26 8:45 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-07-03 1:52 UTC (permalink / raw)
To: 'Oskar Andero', linux-kernel, linux-fbdev
Cc: 'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', 'Radovan Lekanovic',
'Shingo Nakao', 'Milo Kim',
'Richard Purdie', Jingoo Han
On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:
>
> From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode = PWM_BASED) {
> --
> 1.8.1.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
2013-07-02 12:15 [PATCH] backlight: lp855x: set zero brightness at FBBLANK Oskar Andero
2013-07-02 23:24 ` Kim, Milo
2013-07-03 1:52 ` Jingoo Han
@ 2013-07-26 8:45 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 8:45 UTC (permalink / raw)
To: Oskar Andero
Cc: linux-kernel, linux-fbdev, Jean-Christophe Plagniol-Villard,
Radovan Lekanovic, Shingo Nakao, Milo Kim, Richard Purdie
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On 02/07/13 15:15, Oskar Andero wrote:
> From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
>
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-26 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-02 12:15 [PATCH] backlight: lp855x: set zero brightness at FBBLANK Oskar Andero
2013-07-02 23:24 ` Kim, Milo
2013-07-03 1:52 ` Jingoo Han
2013-07-26 8:45 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).