From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Date: Fri, 02 Aug 2013 23:39:11 +0000 Subject: Re: [PATCH RESEND 0/8] x86 platform framebuffers Message-Id: <51FC431F.1080405@zytor.com> List-Id: References: <1375445127-15480-1-git-send-email-dh.herrmann@gmail.com> In-Reply-To: <1375445127-15480-1-git-send-email-dh.herrmann@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: David Herrmann Cc: linux-kernel@vger.kernel.org, David Airlie , Geert Uytterhoeven , Stephen Warren , Peter Jones , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Ingo Molnar , Thomas Gleixner , x86@kernel.org, linux-fbdev@vger.kernel.org, akpm@linux-foundation.org On 08/02/2013 05:05 AM, David Herrmann wrote: > Hi > > I cut down my previous series to no longer include the SimpleDRM driver. If > anyone is interested, you can find it here: > http://lwn.net/Articles/558104/ > I will resend it once these preparation patches are in. > > Changes since v2: > - added common x86 formats (reported by hpa) (patch #5) > > This whole series (including simpledrm) is tested by Stephen and me. I would be > glad if maintainers could ack/nack this so I can continue my work. > > This series is pretty small and just converts x86 to use platform-devices > instead of global objects to pass framebuffer data to drivers. The commit > messages explain everything in detail. > The idea is to create a "platform-framebuffer" device which drivers can bind to. > If x86 boot code detectes efi or vesa framebuffers, it creates efi-framebuffer > or vesa-framebuffer devices instead. > > Additionally, if the modes are compatible, "simple-framebuffer" devices are > created so simplefb can be used on x86. This feature is only enabled if > CONFIG_X86_SYSFB is selected (off by default) so users without simplefb still > get boot logs. > > @Stephen: I wasn't sure whether you tested the efi/vesa framebuffer changes, > too, so I didn't add your tested-by there. And I changed patch #5 so I dropped > it there, too. Thanks for testing! > I am getting a bunch of new warnings with this patchset, typically of the form: /home/hpa/kernel/distwork/drivers/video/arkfb.c:1019:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] par->state.vgabase = (void __iomem *) vga_res.start; ^ /home/hpa/kernel/distwork/drivers/video/s3fb.c: In function ‘s3_pci_probe’: /home/hpa/kernel/distwork/drivers/video/s3fb.c:1186:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] par->state.vgabase = (void __iomem *) vga_res.start; ^ I have pushed it out to a topic branch in the tip tree, partly to give Fengguang's build bot a run at it (it is excellent at spotting the origin of new warnings), but this needs to be fixed; we will not merge this branch in its current form. -hpa