* [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata()
@ 2013-09-17 5:10 Jingoo Han
2013-09-17 14:19 ` Kristoffer Eriksson
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-09-17 5:10 UTC (permalink / raw)
To: linux-fbdev
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/s1d13xxxfb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/s1d13xxxfb.c b/drivers/video/s1d13xxxfb.c
index 05c2dc3..1399a46 100644
--- a/drivers/video/s1d13xxxfb.c
+++ b/drivers/video/s1d13xxxfb.c
@@ -777,8 +777,8 @@ static int s1d13xxxfb_probe(struct platform_device *pdev)
printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
/* enable platform-dependent hardware glue, if any */
- if (pdev->dev.platform_data)
- pdata = pdev->dev.platform_data;
+ if (dev_get_platdata(&pdev->dev))
+ pdata = dev_get_platdata(&pdev->dev);
if (pdata && pdata->platform_init_video)
pdata->platform_init_video();
@@ -923,8 +923,8 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
lcd_enable(s1dfb, 0);
crt_enable(s1dfb, 0);
- if (dev->dev.platform_data)
- pdata = dev->dev.platform_data;
+ if (dev_get_platdata(&dev->dev))
+ pdata = dev_get_platdata(&dev->dev);
#if 0
if (!s1dfb->disp_save)
@@ -973,8 +973,8 @@ static int s1d13xxxfb_resume(struct platform_device *dev)
while ((s1d13xxxfb_readreg(s1dfb, S1DREG_PS_STATUS) & 0x01))
udelay(10);
- if (dev->dev.platform_data)
- pdata = dev->dev.platform_data;
+ if (dev_get_platdata(&dev->dev))
+ pdata = dev_get_platdata(&dev->dev);
if (s1dfb->regs_save) {
/* will write RO regs, *should* get away with it :) */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata()
2013-09-17 5:10 [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata() Jingoo Han
@ 2013-09-17 14:19 ` Kristoffer Eriksson
0 siblings, 0 replies; 2+ messages in thread
From: Kristoffer Eriksson @ 2013-09-17 14:19 UTC (permalink / raw)
To: linux-fbdev
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Jingoo Han skrev 2013-09-17 07:10:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/s1d13xxxfb.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/s1d13xxxfb.c b/drivers/video/s1d13xxxfb.c
> index 05c2dc3..1399a46 100644
> --- a/drivers/video/s1d13xxxfb.c
> +++ b/drivers/video/s1d13xxxfb.c
> @@ -777,8 +777,8 @@ static int s1d13xxxfb_probe(struct platform_device *pdev)
> printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
>
> /* enable platform-dependent hardware glue, if any */
> - if (pdev->dev.platform_data)
> - pdata = pdev->dev.platform_data;
> + if (dev_get_platdata(&pdev->dev))
> + pdata = dev_get_platdata(&pdev->dev);
>
> if (pdata && pdata->platform_init_video)
> pdata->platform_init_video();
> @@ -923,8 +923,8 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
> lcd_enable(s1dfb, 0);
> crt_enable(s1dfb, 0);
>
> - if (dev->dev.platform_data)
> - pdata = dev->dev.platform_data;
> + if (dev_get_platdata(&dev->dev))
> + pdata = dev_get_platdata(&dev->dev);
>
> #if 0
> if (!s1dfb->disp_save)
> @@ -973,8 +973,8 @@ static int s1d13xxxfb_resume(struct platform_device *dev)
> while ((s1d13xxxfb_readreg(s1dfb, S1DREG_PS_STATUS) & 0x01))
> udelay(10);
>
> - if (dev->dev.platform_data)
> - pdata = dev->dev.platform_data;
> + if (dev_get_platdata(&dev->dev))
> + pdata = dev_get_platdata(&dev->dev);
>
> if (s1dfb->regs_save) {
> /* will write RO regs, *should* get away with it :) */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-17 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 5:10 [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata() Jingoo Han
2013-09-17 14:19 ` Kristoffer Eriksson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).