From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/4] video: vfb: Remove incorrect check
Date: Thu, 26 Sep 2013 09:10:43 +0000 [thread overview]
Message-ID: <5243FA13.9050801@ti.com> (raw)
In-Reply-To: <1380110579-3665-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 25/09/13 15:02, Sachin Kamat wrote:
> 'yoffset' is unsigned and hence cannot be less than 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/vfb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
> index ee5985e..ea2b523 100644
> --- a/drivers/video/vfb.c
> +++ b/drivers/video/vfb.c
> @@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> if (var->vmode & FB_VMODE_YWRAP) {
> - if (var->yoffset < 0
> - || var->yoffset >= info->var.yres_virtual
> - || var->xoffset)
> + if (var->yoffset >= info->var.yres_virtual ||
> + var->xoffset)
> return -EINVAL;
> } else {
> if (var->xoffset + info->var.xres > info->var.xres_virtual ||
>
Thanks, queueng the series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
prev parent reply other threads:[~2013-09-26 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 12:14 [PATCH 1/4] video: vfb: Remove incorrect check Sachin Kamat
2013-09-26 9:10 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243FA13.9050801@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).