* [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata() [not found] <27e289763bbcb7d10f84081543cfc3a4dc770398.1380793579.git.michal.simek@xilinx.com> @ 2013-10-03 9:46 ` Michal Simek 2013-10-09 8:44 ` Tomi Valkeinen 0 siblings, 1 reply; 2+ messages in thread From: Michal Simek @ 2013-10-03 9:46 UTC (permalink / raw) To: linux-kernel, monstr Cc: Russell King, Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev [-- Attachment #1: Type: text/plain, Size: 777 bytes --] Driver core clears the driver data to NULL after device_release or on probe failure, so just remove it from here. Driver core change: "device-core: Ensure drvdata = NULL when no driver is bound" (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d) Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/video/amba-clcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c index 0a2cce7..0bab6ab 100644 --- a/drivers/video/amba-clcd.c +++ b/drivers/video/amba-clcd.c @@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev) { struct clcd_fb *fb = amba_get_drvdata(dev); - amba_set_drvdata(dev, NULL); - clcdfb_disable(fb); unregister_framebuffer(&fb->fb); if (fb->fb.cmap.len) -- 1.8.2.3 [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata() 2013-10-03 9:46 ` [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata() Michal Simek @ 2013-10-09 8:44 ` Tomi Valkeinen 0 siblings, 0 replies; 2+ messages in thread From: Tomi Valkeinen @ 2013-10-09 8:44 UTC (permalink / raw) To: Michal Simek Cc: linux-kernel, monstr, Russell King, Jean-Christophe Plagniol-Villard, linux-fbdev [-- Attachment #1: Type: text/plain, Size: 944 bytes --] On 03/10/13 12:46, Michal Simek wrote: > Driver core clears the driver data to NULL after device_release > or on probe failure, so just remove it from here. > > Driver core change: > "device-core: Ensure drvdata = NULL when no driver is bound" > (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > drivers/video/amba-clcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c > index 0a2cce7..0bab6ab 100644 > --- a/drivers/video/amba-clcd.c > +++ b/drivers/video/amba-clcd.c > @@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev) > { > struct clcd_fb *fb = amba_get_drvdata(dev); > > - amba_set_drvdata(dev, NULL); > - > clcdfb_disable(fb); > unregister_framebuffer(&fb->fb); > if (fb->fb.cmap.len) > -- > 1.8.2.3 > Thanks, queued for 3.13. Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 901 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-09 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <27e289763bbcb7d10f84081543cfc3a4dc770398.1380793579.git.michal.simek@xilinx.com>
2013-10-03 9:46 ` [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata() Michal Simek
2013-10-09 8:44 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).