From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Taras Kondratiuk <taras.kondratiuk@linaro.org>,
linux-omap@vger.kernel.org
Cc: linaro-networking@linaro.org,
Victor Kamensky <victor.kamensky@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 03/23] OMAPDSS: raw read and write endian fix
Date: Mon, 18 Nov 2013 13:13:22 +0000 [thread overview]
Message-ID: <528A1272.5060905@ti.com> (raw)
In-Reply-To: <1384560086-11994-4-git-send-email-taras.kondratiuk@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On 2013-11-16 02:01, Taras Kondratiuk wrote:
> From: Victor Kamensky <victor.kamensky@linaro.org>
>
> All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
> Need to use endian neutral functions to read/write h/w registers.
> I.e instead of __raw_read[lw] and __raw_write[lw] functions code
> need to use read[lw]_relaxed and write[lw]_relaxed functions.
> If the first simply reads/writes register, the second will byteswap
> it if host operates in BE mode.
>
> Changes are trivial sed like replacement of __raw_xxx functions
> with xxx_relaxed variant.
>
Looks fine to me. Quick test with o4 panda works fine.
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
prev parent reply other threads:[~2013-11-18 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384560086-11994-1-git-send-email-taras.kondratiuk@linaro.org>
2013-11-16 0:01 ` [RFC 03/23] OMAPDSS: raw read and write endian fix Taras Kondratiuk
2013-11-18 13:13 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A1272.5060905@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linaro-networking@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=taras.kondratiuk@linaro.org \
--cc=victor.kamensky@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).