From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Tue, 26 Nov 2013 08:22:05 +0000 Subject: Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver Message-Id: <52945A2D.3060609@monstr.eu> MIME-Version: 1 Content-Type: multipart/mixed; boundary="90eg0j04mle2pLMcM9CcV4Vm1qT8wPlCQ" List-Id: References: <1385094870-6962-1-git-send-email-stefan.kristiansson@saunalahti.fi> <52944976.4060003@monstr.eu> In-Reply-To: To: Geert Uytterhoeven Cc: Stefan Kristiansson , "linux-kernel@vger.kernel.org" , Linux Fbdev development list , Tomi Valkeinen , Jean-Christophe PLAGNIOL-VILLARD This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --90eg0j04mle2pLMcM9CcV4Vm1qT8wPlCQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/26/2013 09:19 AM, Geert Uytterhoeven wrote: > On Tue, Nov 26, 2013 at 8:10 AM, Michal Simek wrote:= >> On 11/22/2013 05:34 AM, Stefan Kristiansson wrote: >> This construction seems to me too complicated and can be simpler. >> >> What about this? >> res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); >=20 > Don't forget to check for res being non-NULL here. yes. you are right - you have to do it. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --90eg0j04mle2pLMcM9CcV4Vm1qT8wPlCQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKUWi0ACgkQykllyylKDCHtjgCeLRDFAkz6taISawsAzgFWRrp1 a8QAmwaYWpLHZcf2iR0sC9kg0CO+k1eI =zqTk -----END PGP SIGNATURE----- --90eg0j04mle2pLMcM9CcV4Vm1qT8wPlCQ--