From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch 1/2] video: mmp: delete a stray mutex_unlock()
Date: Sat, 14 Dec 2013 07:27:09 +0000 [thread overview]
Message-ID: <52AC084D.9070307@gmail.com> (raw)
In-Reply-To: <20131114081918.GB8150@elgon.mountain>
On 12/13/2013 09:11 PM, Dan Carpenter wrote:
> Ping.
>
> regards,
> dan carpenter
>
> On Thu, Nov 14, 2013 at 11:19:18AM +0300, Dan Carpenter wrote:
>> We aren't holding the disp_lock so we shouldn't release it.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/video/mmp/core.c b/drivers/video/mmp/core.c
>> index 84de263..c8d4265 100644
>> --- a/drivers/video/mmp/core.c
>> +++ b/drivers/video/mmp/core.c
>> @@ -173,7 +173,7 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info)
>> + sizeof(struct mmp_overlay) * info->overlay_num;
>> path = kzalloc(size, GFP_KERNEL);
>> if (!path)
>> - goto failed;
>> + return NULL;
>>
>> /* path set */
>> mutex_init(&path->access_ok);
>> @@ -219,11 +219,6 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info)
>>
>> mutex_unlock(&disp_lock);
>> return path;
>> -
>> -failed:
>> - kfree(path);
>> - mutex_unlock(&disp_lock);
>> - return NULL;
>> }
>> EXPORT_SYMBOL_GPL(mmp_register_path);
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Jean,
Could you help to merge this fix?
Regards
Haojian
next prev parent reply other threads:[~2013-12-14 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 8:19 [patch 1/2] video: mmp: delete a stray mutex_unlock() Dan Carpenter
2013-12-13 13:11 ` Dan Carpenter
2013-12-14 7:27 ` Haojian Zhuang [this message]
2014-01-10 11:29 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AC084D.9070307@gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).