From: Levente Kurusa <levex@linux.com>
To: Jingoo Han <jg1.han@samsung.com>,
'Andrew Morton' <akpm@linux-foundation.org>
Cc: 'LKML' <linux-kernel@vger.kernel.org>,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails
Date: Mon, 16 Dec 2013 17:16:14 +0000 [thread overview]
Message-ID: <52AF355E.3080105@linux.com> (raw)
In-Reply-To: <006f01cefa1a$97ea4710$c7bed530$%han@samsung.com>
On 12/16/2013 05:52 AM, Jingoo Han wrote:
> On Saturday, December 14, 2013 3:40 AM, Levente Kurusa wrote:
>>
>> Currently we kfree the container of the device which failed to register.
>> This is wrong as the last reference is not given up with a put_device
>> call. Also, now that we have put_device() callen, we no longer need
>> the kfree as the new_ld->dev.release function will take care of kfreeing
>> the associated memory.
>>
>> Signed-off-by: Levente Kurusa <levex@linux.com>
>
> (+cc Andrew Morton)
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
> It looks good.
> According to the comment of device_register, put_device()
> should be used, instead of directly freeing.
Indeed, this is also mostly explained in [0/4]. Thanks for the Ack!
>
[...]
>
> Levente Kurusa,
> By the way, don't send the same mails three times, without any
> reason. It is the waste of traffic. :-(
>
Yea, sorry about that I messed up my git's smtp config and hence most of the
messages bounced off. It didn't even reach LKML. Sorry once more.
--
Regards,
Levente Kurusa
next prev parent reply other threads:[~2013-12-16 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386959996-7958-1-git-send-email-levex@linux.com>
[not found] ` <1386959996-7958-4-git-send-email-levex@linux.com>
2013-12-16 4:52 ` [PATCH 3/4] backlight: lcd: call put_device if device_register fails Jingoo Han
2013-12-16 17:16 ` Levente Kurusa [this message]
2014-01-07 1:42 ` Jingoo Han
[not found] <1386962557-8899-1-git-send-email-levex@linux.com>
2013-12-13 19:22 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF355E.3080105@linux.com \
--to=levex@linux.com \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).