From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivaylo Dimitrov Date: Sun, 05 Jan 2014 12:58:17 +0000 Subject: Re: [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing mutex unlocks Message-Id: <52C956E9.2030008@gmail.com> List-Id: References: <1388420272-5132-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <20140104125108.GA22339@amd.pavel.ucw.cz> In-Reply-To: <20140104125108.GA22339@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pavel Machek , Ivaylo Dimitrov Cc: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com, pali.rohar@gmail.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ivaylo Dimitrov On 04.01.2014 14:51, Pavel Machek wrote: > On Mon 2013-12-30 18:17:52, Ivaylo Dimitrov wrote: >> From: Ivaylo Dimitrov >> >> Commit c37dd677988ca50bc8bc60ab5ab053720583c168 fixes the unbalanced >> unlock in acx565akm_enable but introduces another problem - if >> acx565akm_panel_power_on exits early, the mutex is not unlocked. Fix >> that by unlocking the mutex on early return. Also add mutex protection in >> acx565akm_panel_power_off and remove an unused variable >> >> Signed-off-by: Ivaylo Dimitrov > Reviewed-by: Pavel Machek Hmm, I introduced a bug with that patch (recursive lock), will send a new version that fixes it Regards, Ivo