From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata()
Date: Wed, 08 Jan 2014 08:33:31 +0000 [thread overview]
Message-ID: <52CD0D5B.9060102@ti.com> (raw)
In-Reply-To: <001901cf0c0a$cb48b5e0$61da21a0$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 2014-01-08 02:44, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/asiliantfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/asiliantfb.c b/drivers/video/asiliantfb.c
> index d611f1a..7e8ddf0 100644
> --- a/drivers/video/asiliantfb.c
> +++ b/drivers/video/asiliantfb.c
> @@ -589,7 +589,6 @@ static void asiliantfb_remove(struct pci_dev *dp)
> fb_dealloc_cmap(&p->cmap);
> iounmap(p->screen_base);
> release_mem_region(pci_resource_start(dp, 0), pci_resource_len(dp, 0));
> - pci_set_drvdata(dp, NULL);
> framebuffer_release(p);
> }
>
>
Series queued for 3.14.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
prev parent reply other threads:[~2014-01-08 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 0:44 [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata() Jingoo Han
2014-01-08 8:33 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD0D5B.9060102@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).