* [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata()
@ 2014-01-08 0:44 Jingoo Han
2014-01-08 8:33 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2014-01-08 0:44 UTC (permalink / raw)
To: linux-fbdev
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/asiliantfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/asiliantfb.c b/drivers/video/asiliantfb.c
index d611f1a..7e8ddf0 100644
--- a/drivers/video/asiliantfb.c
+++ b/drivers/video/asiliantfb.c
@@ -589,7 +589,6 @@ static void asiliantfb_remove(struct pci_dev *dp)
fb_dealloc_cmap(&p->cmap);
iounmap(p->screen_base);
release_mem_region(pci_resource_start(dp, 0), pci_resource_len(dp, 0));
- pci_set_drvdata(dp, NULL);
framebuffer_release(p);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata()
2014-01-08 0:44 [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2014-01-08 8:33 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-01-08 8:33 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 2014-01-08 02:44, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/asiliantfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/asiliantfb.c b/drivers/video/asiliantfb.c
> index d611f1a..7e8ddf0 100644
> --- a/drivers/video/asiliantfb.c
> +++ b/drivers/video/asiliantfb.c
> @@ -589,7 +589,6 @@ static void asiliantfb_remove(struct pci_dev *dp)
> fb_dealloc_cmap(&p->cmap);
> iounmap(p->screen_base);
> release_mem_region(pci_resource_start(dp, 0), pci_resource_len(dp, 0));
> - pci_set_drvdata(dp, NULL);
> framebuffer_release(p);
> }
>
>
Series queued for 3.14.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-08 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 0:44 [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata() Jingoo Han
2014-01-08 8:33 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).