From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
stable@vger.kernel.org
Subject: Re: [PATCH] fbcon: Avoid corrupting active workqueue entries
Date: Fri, 10 Jan 2014 11:24:13 +0000 [thread overview]
Message-ID: <52CFD85D.8020204@ti.com> (raw)
In-Reply-To: <1387290459-26440-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Hi,
On 2013-12-17 16:27, Chris Wilson wrote:
> We attempt to reschedule an active work which can itself corrupt the
> workqueue lists, and we may then free the work item whilst the task is
> still pending. Both of these may lead to a system deadlock and an
> unresponsive machine without any outputs for a panic to even be shown.
This gives the following warning:
drivers/video/console/fbcon.c:407:20: warning: unused variable ‘ops’
[-Wunused-variable]
I can fix that. Or maybe it's better if you send a v2 with that fixed,
so that this gets properly to stable-kernel.
However, I wouldn't mind an acked-by or reviewed-by from someone.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-01-10 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 14:27 [PATCH] fbcon: Avoid corrupting active workqueue entries Chris Wilson
2014-01-10 11:24 ` Tomi Valkeinen [this message]
2014-01-10 17:25 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CFD85D.8020204@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).