[PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Mark Brown]

From: Mark Brown <broonie@linaro.org>

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64
to the list of dependencies. The driver also has no build time dependencies
on ARM (stubs are provided for ARM-specific DMA functions in the code) so
make it available with COMPILE_TEST in order to maximise build coverage.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/video/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 4f2e1b35eb38..e6c7fb1a389b 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
 
 config FB_ARMCLCD
 	tristate "ARM PrimeCell PL110 support"
-	depends on FB && ARM && ARM_AMBA
+	depends on ARM || ARM64 || COMPILE_TEST
+	depends on FB && ARM_AMBA
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.8.5.1

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Geert Uytterhoeven]

On Thu, Dec 12, 2013 at 6:13 PM, Mark Brown <broonie@kernel.org> wrote:
> The CLCD driver is used on ARM reference models for ARMv8 so add ARM64
> to the list of dependencies. The driver also has no build time dependencies
> on ARM (stubs are provided for ARM-specific DMA functions in the code) so
> make it available with COMPILE_TEST in order to maximise build coverage.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/video/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 4f2e1b35eb38..e6c7fb1a389b 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
>
>  config FB_ARMCLCD
>         tristate "ARM PrimeCell PL110 support"
> -       depends on FB && ARM && ARM_AMBA
> +       depends on ARM || ARM64 || COMPILE_TEST
> +       depends on FB && ARM_AMBA
>         select FB_CFB_FILLRECT
>         select FB_CFB_COPYAREA
>         select FB_CFB_IMAGEBLIT

Currently ARM_AMBA exists on arm/arm64 only.
Is there a patch in the pipeline to change that? Without such a change,
this patch doesn't make any difference.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Thu, Dec 12, 2013 at 06:48:49PM +0100, Geert Uytterhoeven wrote:

> Currently ARM_AMBA exists on arm/arm64 only.
> Is there a patch in the pipeline to change that? Without such a change,

I don't know but it's plausible given how common AMBA is.

> this patch doesn't make any difference.

No, it does mean that ARM64 is included - previously the dependency was
only on ARM so it wasn't available on ARM64.  COMPILE_TEST won't have an
impact though.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Geert Uytterhoeven]

On Thu, Dec 12, 2013 at 7:07 PM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Dec 12, 2013 at 06:48:49PM +0100, Geert Uytterhoeven wrote:
>
>> Currently ARM_AMBA exists on arm/arm64 only.
>> Is there a patch in the pipeline to change that? Without such a change,
>
> I don't know but it's plausible given how common AMBA is.
>
>> this patch doesn't make any difference.
>
> No, it does mean that ARM64 is included - previously the dependency was

Sure.

> only on ARM so it wasn't available on ARM64.  COMPILE_TEST won't have an
> impact though.

Sorry, I meant it doesn't have any impact on COMPILE_TEST.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Catalin Marinas]

On 12 December 2013 17:13, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The CLCD driver is used on ARM reference models for ARMv8 so add ARM64
> to the list of dependencies. The driver also has no build time dependencies
> on ARM (stubs are provided for ARM-specific DMA functions in the code) so
> make it available with COMPILE_TEST in order to maximise build coverage.

I haven't followed other CLCD patches but for arm64 it requires
support for DT. I have been carrying some patches (done by Linaro) for
a long time and Pawel @ ARM has another set of patches. Do you know
what the status for those is before enabling CLCD on arm64? That's
unless you are only looking at compile-testing.

-- 
Catalin

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Tue, Dec 17, 2013 at 04:27:34PM +0000, Catalin Marinas wrote:
> On 12 December 2013 17:13, Mark Brown <broonie@kernel.org> wrote:

> > The CLCD driver is used on ARM reference models for ARMv8 so add ARM64
> > to the list of dependencies. The driver also has no build time dependencies
> > on ARM (stubs are provided for ARM-specific DMA functions in the code) so
> > make it available with COMPILE_TEST in order to maximise build coverage.

> I haven't followed other CLCD patches but for arm64 it requires
> support for DT. I have been carrying some patches (done by Linaro) for
> a long time and Pawel @ ARM has another set of patches. Do you know
> what the status for those is before enabling CLCD on arm64? That's
> unless you are only looking at compile-testing.

Pawel's patches are going nowhere slowly as far as I can tell due to a
slow feedback loop and extensive discussion of the DT bindings.  

I think this patch is an orthogonal thing, though - as you say it's
useful for compile testing on its own and it means the driver will load
as soon as the DT bindings are supported.  It's one less patch to carry
out of tree and one less iteration when debugging why the framebuffer
isn't supported when testing.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] video: amba-clcd: Make CLCD driver available on more platforms

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On 2013-12-12 19:13, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> The CLCD driver is used on ARM reference models for ARMv8 so add ARM64
> to the list of dependencies. The driver also has no build time dependencies
> on ARM (stubs are provided for ARM-specific DMA functions in the code) so
> make it available with COMPILE_TEST in order to maximise build coverage.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/video/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 4f2e1b35eb38..e6c7fb1a389b 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
>  
>  config FB_ARMCLCD
>  	tristate "ARM PrimeCell PL110 support"
> -	depends on FB && ARM && ARM_AMBA
> +	depends on ARM || ARM64 || COMPILE_TEST
> +	depends on FB && ARM_AMBA
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
>  	select FB_CFB_IMAGEBLIT
> 

Queued for 3.14.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]