* [PATCH 0/4] delete useless variable @ 2014-01-13 15:22 Julia Lawall 2014-01-13 15:22 ` [PATCH 2/4] i810: " Julia Lawall 0 siblings, 1 reply; 3+ messages in thread From: Julia Lawall @ 2014-01-13 15:22 UTC (permalink / raw) To: brcm80211-dev-list Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, linux-fbdev, devel These patches delete declarations and initializations of variables that are only assigned to constants but never used otherwise. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ type T; identifier i,i2; position p; @@ T i@p; ... i = i2 @@ type r.T; identifier r.i; constant c; position p != r.p; @@ -T i@p; <... when != i -i = c; ...> // </smpl> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/4] i810: delete useless variable 2014-01-13 15:22 [PATCH 0/4] delete useless variable Julia Lawall @ 2014-01-13 15:22 ` Julia Lawall 2014-01-14 8:06 ` Tomi Valkeinen 0 siblings, 1 reply; 3+ messages in thread From: Julia Lawall @ 2014-01-13 15:22 UTC (permalink / raw) To: Antonino Daplas Cc: kernel-janitors, Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Delete a variable that is at most only assigned to a constant, but never used otherwise. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; identifier i; constant c; @@ -T i; <... when != i -i = c; ...> // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/video/i810/i810_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c index 038192a..bb674e4 100644 --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c @@ -2011,9 +2011,7 @@ static int i810fb_init_pci(struct pci_dev *dev, struct fb_info *info; struct i810fb_par *par = NULL; struct fb_videomode mode; - int i, err = -1, vfreq, hfreq, pixclock; - - i = 0; + int err = -1, vfreq, hfreq, pixclock; info = framebuffer_alloc(sizeof(struct i810fb_par), &dev->dev); if (!info) ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] i810: delete useless variable 2014-01-13 15:22 ` [PATCH 2/4] i810: " Julia Lawall @ 2014-01-14 8:06 ` Tomi Valkeinen 0 siblings, 0 replies; 3+ messages in thread From: Tomi Valkeinen @ 2014-01-14 8:06 UTC (permalink / raw) To: Julia Lawall Cc: Antonino Daplas, kernel-janitors, Jean-Christophe Plagniol-Villard, linux-fbdev, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1218 bytes --] On 2014-01-13 18:17, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Delete a variable that is at most only assigned to a constant, but never > used otherwise. > > A simplified version of the semantic patch that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > type T; > identifier i; > constant c; > @@ > > -T i; > <... when != i > -i = c; > ...> > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/video/i810/i810_main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c > index 038192a..bb674e4 100644 > --- a/drivers/video/i810/i810_main.c > +++ b/drivers/video/i810/i810_main.c > @@ -2011,9 +2011,7 @@ static int i810fb_init_pci(struct pci_dev *dev, > struct fb_info *info; > struct i810fb_par *par = NULL; > struct fb_videomode mode; > - int i, err = -1, vfreq, hfreq, pixclock; > - > - i = 0; > + int err = -1, vfreq, hfreq, pixclock; > > info = framebuffer_alloc(sizeof(struct i810fb_par), &dev->dev); > if (!info) > Thanks, queued for 3.14. Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 901 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-14 8:06 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-13 15:22 [PATCH 0/4] delete useless variable Julia Lawall 2014-01-13 15:22 ` [PATCH 2/4] i810: " Julia Lawall 2014-01-14 8:06 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).