Re: [PATCH 1/2] video: exynos: Remove OF dependency for Exynos DP

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 11/02/14 14:01, Sachin Kamat wrote:
> On 10 February 2014 17:48, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 17/01/14 06:32, Sachin Kamat wrote:
>>> Exynos is now a DT only platform. Hence there is no need
>>> for an explicit OF dependency. Remove it.
>>
>> But the driver still depends on OF, doesn't it? I don't think it's very
>> good for the driver Kconfig to make presumptions about what ARCH_*
>> depend on.
> 
> Depending upon nested dependencies is redundant IMHO.

Well, a driver should be independent of the underlying arch. In
practice, we have ARCH dependencies, as many of the devices only exist
on that arch. But I think the drivers should still be designed to be
arch-independent, as far as possible (omapdss compiles fine on x86).

If the driver depends on OF, it should depend on OF in the Kconfig, no
matter if the arch also depends on OF.

I don't really care if the EXYNOS_LCD_S6E8AX0 has OF dependency or not,
but to me this just looks unneeded cleanup, cluttering git logs, and in
my opinion it's even going to the wrong direction.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]