From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.capella@linaro.org Date: Tue, 18 Feb 2014 22:20:42 +0000 Subject: Re: [v2] backlight: Convert from Legacy pm ops to dev_pm_ops Message-Id: <5303dcb6.2587440a.3f18.fffff1ba@mx.google.com> List-Id: References: <2236505237-3336-1-git-send-email-shuah.kh@samsung.com> In-Reply-To: <2236505237-3336-1-git-send-email-shuah.kh@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: tomi.valkeinen@ti.com, shuah.kh@samsung.com, rpurdie@rpsys.net, rafael.j.wysocki@intel.com, plagnioj@jcrosoft.com, FlorianSchandinat@gmx.de Cc: shuahkhan@gmail.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Shuah Khan wrote: > Convert drivers/video/backlight/class to use dev_pm_ops for power > management and remove Legacy PM ops hooks. With this change, rtc class > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of > Legacy class->suspend/resume. When __device_suspend() runs call-backs, > it will find class->pm ops for the backlight class. > > Signed-off-by: Shuah Khan > Cc: Shuah Khan > > --- > v2: Updated changelog to correct device class. > > drivers/video/backlight/backlight.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index c74e7aa..0ffb251 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, > > static struct class *backlight_class; > > -static int backlight_suspend(struct device *dev, pm_message_t state) > +static int backlight_suspend(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > > @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) > return 0; > } > > +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, > + backlight_resume); > + > static void bl_device_release(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) > } > > backlight_class->dev_attrs = bl_device_attributes; > - backlight_class->suspend = backlight_suspend; > - backlight_class->resume = backlight_resume; > + backlight_class->pm = &backlight_class_dev_pm_ops; > return 0; > } >