linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch -resend] sisfb: fix 1280x720 resolution support
@ 2014-03-07 11:18 Dan Carpenter
  2014-03-07 12:20 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-03-07 11:18 UTC (permalink / raw)
  To: linux-fbdev

It uses the wrong mode index because there is no break statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
index 4f26bc28e60b..bd40f5ecd901 100644
--- a/drivers/video/fbdev/sis/init.c
+++ b/drivers/video/fbdev/sis/init.c
@@ -651,6 +651,7 @@ SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay, int VDispla
 	     switch(VDisplay) {
 	     case 720:
 		ModeIndex = ModeIndex_1280x720[Depth];
+		break;
 	     case 768:
 		if(VGAEngine = SIS_300_VGA) {
 		   ModeIndex = ModeIndex_300_1280x768[Depth];

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch -resend] sisfb: fix 1280x720 resolution support
  2014-03-07 11:18 [patch -resend] sisfb: fix 1280x720 resolution support Dan Carpenter
@ 2014-03-07 12:20 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-03-07 12:20 UTC (permalink / raw)
  To: linux-fbdev

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

On 07/03/14 13:18, Dan Carpenter wrote:
> It uses the wrong mode index because there is no break statement.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
> index 4f26bc28e60b..bd40f5ecd901 100644
> --- a/drivers/video/fbdev/sis/init.c
> +++ b/drivers/video/fbdev/sis/init.c
> @@ -651,6 +651,7 @@ SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay, int VDispla
>  	     switch(VDisplay) {
>  	     case 720:
>  		ModeIndex = ModeIndex_1280x720[Depth];
> +		break;
>  	     case 768:
>  		if(VGAEngine == SIS_300_VGA) {
>  		   ModeIndex = ModeIndex_300_1280x768[Depth];
> 

Thanks, queued for 3.15.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-07 12:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 11:18 [patch -resend] sisfb: fix 1280x720 resolution support Dan Carpenter
2014-03-07 12:20 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).