From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Tue, 18 Mar 2014 07:06:16 +0000 Subject: Re: [PATCH 5/9] Doc/DT: Add DT binding documentation for MIPI DPI Panel Message-Id: <5327F068.7010100@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="e2lmthRX2peGv5gJFecsMSCJFNR8KJ98E" List-Id: References: <1393590016-9361-1-git-send-email-tomi.valkeinen@ti.com> <1393590016-9361-6-git-send-email-tomi.valkeinen@ti.com> <3721050.m43feCICLQ@avalon> <5327EAB3.8080405@ti.com> In-Reply-To: <5327EAB3.8080405@ti.com> To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Russell King - ARM Linux , Sascha Hauer , Tomasz Figa , dri-devel@lists.freedesktop.org, Inki Dae , Andrzej Hajda , Rob Clark , Thierry Reding , Philipp Zabel , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth --e2lmthRX2peGv5gJFecsMSCJFNR8KJ98E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 18/03/14 08:41, Tomi Valkeinen wrote: > On 17/03/14 16:19, Laurent Pinchart wrote: >=20 >>> +Generic MIPI DPI Panel >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> + >>> +Required properties: >>> +- compatible: "panel-dpi" >>> + >>> +Optional properties: >>> +- label: a symbolic name for the panel >>> +- gpios: panel enable gpio and backlight enable gpio >> >> While integrated in the panel module, the backlight is a separate piec= e of=20 >> hardware, which could be controlled through other means (I2C for insta= nce).=20 >> Wouldn't it be better to add an explicit DT node for the backlight dev= ice and=20 >> reference that node from the panel node ? >=20 > Yes, I agree, but do we have the infrastructure or bindings for that? >=20 > Ah, I see we now do have a gpio-backlight driver, but it doesn't have D= T > bindings. Seems there's a patch from Denis Carikli for this, which will probably be merged for 3.15. I realized I don't actually use panel-dpi at the moment in my OMAP DSS DT series, as I dropped the board changes that used panel-dpi. So I'll drop panel-dpi bindings from my series, and the backlight for panel-dpi can then be fixed for 3.16. Tomi --e2lmthRX2peGv5gJFecsMSCJFNR8KJ98E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTJ/BoAAoJEPo9qoy8lh71lHMQAKpLuDMvq0XbZ5igX2V+DnJ7 rrUOBNbRBIhnxFvUuxzd27fVBgDMA4wW8cwowygosjegCrS/Yc8xLeQINhxcAI+e 4tjRsUUNFf3ZbyDxLMX7wcyAig+R0AV8SDKQa/eanuRKa5i7MzOIVONz4tOvKlsQ jCz9GgSR88h5XILiu5DoLXsli+x8XwhwJ545w31YKF2OYIKV5bghCnTb8L5iJpOG h4NLc1HwUx8uIzoK8vqIjdOlkgm5skZlwlp/EMseSfo0gtmAf9exQ3ITN1M5LVDw puxDAiav2EN3513GPch9fSzpc6hwruvVM6ULnu6pp9vrvGywQoZ3AQC7sOp/BwlU PYSIofGgFWLoJ0q+LoXzquCDe13OFsbTy7KJS9wgL6kpnT41AQG5BB/IGGl9ElPu rJzJ89P7nk/QoA+7JhqtWSDrJyUsU+lKrxrU+9HsGwSRxZWCNBDlEJJXS778WCdm qbjxARIsckUAqfFUgqSHey0XelrLnyoiaULvhFeFn7NuNshI+GWxQpg5Lycqy0Pt IkC2XjA3C93fPm7L8lLqTlpqQKMP9zFY0/X0BEJdBpfYEl0HN87IpdaHPupRPqmW XUXgkUoy8b54NRR1TK77psv71DvN0r+kbDcmjaT+++EGbajD0YpitNP2rhs9NC56 cz1tKqVtDQFu2rAG8jOh =h/3y -----END PGP SIGNATURE----- --e2lmthRX2peGv5gJFecsMSCJFNR8KJ98E--