* [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
@ 2014-03-19 7:47 Bo Shen
2014-03-19 9:50 ` Nicolas Ferre
2014-03-19 11:04 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Bo Shen @ 2014-03-19 7:47 UTC (permalink / raw)
To: linux-arm-kernel
Correct passing parameter sequence, which will avoid the id of
fix screen info is overwritten.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
drivers/video/atmel_lcdfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index cd96162..695f28a 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
if (!sinfo->config)
goto free_info;
- strcpy(info->fix.id, sinfo->pdev->name);
info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
info->pseudo_palette = sinfo->pseudo_palette;
info->fbops = &atmel_lcdfb_ops;
info->fix = atmel_lcdfb_fix;
+ strcpy(info->fix.id, sinfo->pdev->name);
/* Enable LCDC Clocks */
sinfo->bus_clk = clk_get(dev, "hclk");
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
2014-03-19 7:47 [PATCH] Video: atmel: avoid the id of fix screen info is overwritten Bo Shen
@ 2014-03-19 9:50 ` Nicolas Ferre
2014-03-19 11:04 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2014-03-19 9:50 UTC (permalink / raw)
To: linux-arm-kernel
On 19/03/2014 08:47, Bo Shen :
> Correct passing parameter sequence, which will avoid the id of
> fix screen info is overwritten.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index cd96162..695f28a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (!sinfo->config)
> goto free_info;
>
> - strcpy(info->fix.id, sinfo->pdev->name);
> info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
> info->pseudo_palette = sinfo->pseudo_palette;
> info->fbops = &atmel_lcdfb_ops;
>
> info->fix = atmel_lcdfb_fix;
> + strcpy(info->fix.id, sinfo->pdev->name);
>
> /* Enable LCDC Clocks */
> sinfo->bus_clk = clk_get(dev, "hclk");
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
2014-03-19 7:47 [PATCH] Video: atmel: avoid the id of fix screen info is overwritten Bo Shen
2014-03-19 9:50 ` Nicolas Ferre
@ 2014-03-19 11:04 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2014-03-19 11:04 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On 19/03/14 09:47, Bo Shen wrote:
> Correct passing parameter sequence, which will avoid the id of
> fix screen info is overwritten.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index cd96162..695f28a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (!sinfo->config)
> goto free_info;
>
> - strcpy(info->fix.id, sinfo->pdev->name);
> info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
> info->pseudo_palette = sinfo->pseudo_palette;
> info->fbops = &atmel_lcdfb_ops;
>
> info->fix = atmel_lcdfb_fix;
> + strcpy(info->fix.id, sinfo->pdev->name);
>
> /* Enable LCDC Clocks */
> sinfo->bus_clk = clk_get(dev, "hclk");
>
Thanks, queued for 3.15.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-19 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-19 7:47 [PATCH] Video: atmel: avoid the id of fix screen info is overwritten Bo Shen
2014-03-19 9:50 ` Nicolas Ferre
2014-03-19 11:04 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).