From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] lcd: Provide dummy functions if CONFIG_LCD_CLASS_DEVICE is not set
Date: Wed, 19 Mar 2014 13:31:49 +0000 [thread overview]
Message-ID: <53299C45.1030300@ti.com> (raw)
In-Reply-To: <1394795353-1931-1-git-send-email-shc_work@mail.ru>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
Hi,
On 14/03/14 13:09, Alexander Shiyan wrote:
> Provide dummy functions for LCD register()/unregister() if
> CONFIG_LCD_CLASS_DEVICE is not set.
> This allows us to use the LCD class as an optional.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> include/linux/lcd.h | 37 ++++++++++++++++++++++++++++++-------
> 1 file changed, 30 insertions(+), 7 deletions(-)
I'm still not convinced about this. Isn't it simpler to just
select/depend on LCD_CLASS_DEVICE? The lcd.c is a bit less than 9 kB, so
it's not like you're adding a huge amount of code into the kernel even
if the driver doesn't happen to use it for a particular display.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-03-19 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 11:09 [PATCH v2] lcd: Provide dummy functions if CONFIG_LCD_CLASS_DEVICE is not set Alexander Shiyan
2014-03-19 13:31 ` Tomi Valkeinen [this message]
2014-03-20 7:08 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53299C45.1030300@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).