From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jim Davis <jim.epost@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] drivers/video: fix mb862xx_i2c depends issue build failure
Date: Fri, 21 Mar 2014 13:53:58 +0000 [thread overview]
Message-ID: <532C4476.2030706@windriver.com> (raw)
In-Reply-To: <532C3F64.2020601@ti.com>
On 14-03-21 09:32 AM, Tomi Valkeinen wrote:
> Hi,
>
> On 20/03/14 17:16, Paul Gortmaker wrote:
>> Any randconfig that sets I2C=m and FB_MB862XX_I2C=y will
>> encounter a final link failure that looks like this:
>
> It compiles fine with I2C=m, FB_MB862XX=m and FB_MB862XX_I2C=y.
>
>> drivers/built-in.o: In function `mb862xx_i2c_init':
>> drivers/video/mb862xx/mb862xx-i2c.c:165: undefined reference to `i2c_add_adapter'
>> drivers/built-in.o: In function `mb862xx_i2c_exit':
>> drivers/video/mb862xx/mb862xx-i2c.c:176: undefined reference to `i2c_del_adapter'
>>
>> Since FB_MB862XX_I2C is a bool and not tristate, simply
>> don't offer it at all if core I2C support is not built in.
>
> FB_MB862XX_I2C is not a driver, it just adds the i2c support to
> FB_MB862XX. The relevant thing is whether FB_MB862XX is m or y, so
> compiling with:
>
> I2C=m, FB_MB862XX=y and FB_MB862XX_I2C=y
>
> will fail.
How would you suggest we fix it then? Perhaps we could simplify the
Kconfig space and just get rid of FB_MB862XX_I2C entirely? Is there
ever a reason why someone would want it turned off when I2C is present?
Paul.
--
>
>> Reported-by: Jim Davis <jim.epost@gmail.com>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>>
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>> index dade5b7699bc..aefd1b9a3cbd 100644
>> --- a/drivers/video/Kconfig
>> +++ b/drivers/video/Kconfig
>> @@ -2338,7 +2338,7 @@ endchoice
>>
>> config FB_MB862XX_I2C
>> bool "Support I2C bus on MB862XX GDC"
>> - depends on FB_MB862XX && I2C
>> + depends on FB_MB862XX && I2C=y
>> default y
>> help
>> Selecting this option adds Coral-P(A)/Lime GDC I2C bus adapter
>
> This fix is not correct, as it prevents the following, valid, config:
>
> I2C=m, FB_MB862XX=m and FB_MB862XX_I2C=y
>
> Tomi
>
>
next prev parent reply other threads:[~2014-03-21 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 15:16 [PATCH] drivers/video: fix mb862xx_i2c depends issue build failure Paul Gortmaker
2014-03-21 13:32 ` Tomi Valkeinen
2014-03-21 13:53 ` Paul Gortmaker [this message]
2014-03-21 14:07 ` Tomi Valkeinen
2014-03-21 23:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C4476.2030706@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=fengguang.wu@intel.com \
--cc=jim.epost@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).