From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Date: Tue, 15 Apr 2014 07:01:44 +0000 Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup Message-Id: <534CD958.4000303@ti.com> List-Id: References: <1397512793-10325-1-git-send-email-alexandre.belloni@free-electrons.com> <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On 04/15/2014 12:59 AM, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-omap2/board-omap3beagle.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap= 2/board-omap3beagle.c > index f27e1ec90b5e..54c135a5b4f7 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -61,14 +61,8 @@ > =20 > static struct pwm_lookup pwm_lookup[] =3D { > /* LEDB -> PMU_STAT */ > - { > - .provider =3D "twl-pwmled", > - .index =3D 1, > - .dev_id =3D "leds_pwm", > - .con_id =3D "beagleboard::pmu_stat", > - .period =3D 7812500, > - .polarity =3D PWM_POLARITY_NORMAL, > - }, > + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat", > + 7812500, PWM_POLARITY_NORMAL), Why do you need to do this in two steps? In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it = back. Would not be simpler if you just add the two new parameters in patch 4 (the 812500, PWM_POLARITY_NORMAL)? > }; > =20 > static struct led_pwm pwm_leds[] =3D { >=20 --=20 P=E9ter