* [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c
@ 2014-04-28 10:54 Masanari Iida
2014-04-28 11:17 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Masanari Iida @ 2014-04-28 10:54 UTC (permalink / raw)
To: plagnioj, tomi.valkeinen, linux-fbdev, linux-omap; +Cc: Masanari Iida
Fix two format string mismatch in display-sysfs.c
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-sysfs.c
index 5a2095a..5928bc9 100644
--- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
+++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
@@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
if (!dssdev->driver->get_rotate)
return -ENOENT;
rotate = dssdev->driver->get_rotate(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
+ return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
}
static ssize_t display_rotate_store(struct device *dev,
@@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
if (!dssdev->driver->get_mirror)
return -ENOENT;
mirror = dssdev->driver->get_mirror(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
+ return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
}
static ssize_t display_mirror_store(struct device *dev,
--
2.0.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c
2014-04-28 10:54 [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c Masanari Iida
@ 2014-04-28 11:17 ` Jingoo Han
2014-04-30 8:43 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-04-28 11:17 UTC (permalink / raw)
To: 'Masanari Iida', 'Tomi Valkeinen'
Cc: 'Jean-Christophe Plagniol-Villard', linux-fbdev,
linux-omap, 'Jingoo Han'
On Monday, April 28, 2014 7:54 PM, Masanari Iida wrote:
>
> Fix two format string mismatch in display-sysfs.c
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-
> sysfs.c
> index 5a2095a..5928bc9 100644
> --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
> +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
> @@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
> if (!dssdev->driver->get_rotate)
> return -ENOENT;
> rotate = dssdev->driver->get_rotate(dssdev);
According to 'struct omap_dss_driver', get_rotate() returns 'u8'.
Then, how about changing the type of 'rotate' variable from 'int'
to 'u8' as below?
--- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
+++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
@@ -180,7 +180,7 @@ static ssize_t display_rotate_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct omap_dss_device *dssdev = to_dss_device_sysfs(dev);
- int rotate;
+ u8 rotate;
if (!dssdev->driver->get_rotate)
return -ENOENT;
rotate = dssdev->driver->get_rotate(dssdev);
Best regards,
Jingoo Han
> - return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
> + return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
> }
>
> static ssize_t display_rotate_store(struct device *dev,
> @@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
> if (!dssdev->driver->get_mirror)
> return -ENOENT;
> mirror = dssdev->driver->get_mirror(dssdev);
> - return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
> + return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
> }
>
> static ssize_t display_mirror_store(struct device *dev,
> --
> 2.0.0.rc1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c
2014-04-28 11:17 ` Jingoo Han
@ 2014-04-30 8:43 ` Tomi Valkeinen
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2014-04-30 8:43 UTC (permalink / raw)
To: Jingoo Han, 'Masanari Iida'
Cc: 'Jean-Christophe Plagniol-Villard', linux-fbdev,
linux-omap
[-- Attachment #1: Type: text/plain, Size: 2094 bytes --]
On 28/04/14 14:17, Jingoo Han wrote:
> On Monday, April 28, 2014 7:54 PM, Masanari Iida wrote:
>>
>> Fix two format string mismatch in display-sysfs.c
>>
>> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
>> ---
>> drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-
>> sysfs.c
>> index 5a2095a..5928bc9 100644
>> --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
>> +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
>> @@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
>> if (!dssdev->driver->get_rotate)
>> return -ENOENT;
>> rotate = dssdev->driver->get_rotate(dssdev);
>
> According to 'struct omap_dss_driver', get_rotate() returns 'u8'.
> Then, how about changing the type of 'rotate' variable from 'int'
> to 'u8' as below?
>
> --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
> +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
> @@ -180,7 +180,7 @@ static ssize_t display_rotate_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct omap_dss_device *dssdev = to_dss_device_sysfs(dev);
> - int rotate;
> + u8 rotate;
> if (!dssdev->driver->get_rotate)
> return -ENOENT;
> rotate = dssdev->driver->get_rotate(dssdev);
>
>
> Best regards,
> Jingoo Han
>
>> - return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
>> + return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
>> }
>>
>> static ssize_t display_rotate_store(struct device *dev,
>> @@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
>> if (!dssdev->driver->get_mirror)
>> return -ENOENT;
>> mirror = dssdev->driver->get_mirror(dssdev);
>> - return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
>> + return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
>> }
And get_mirror returns a bool, not int, so I guess that could be fixed also.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-30 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-28 10:54 [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c Masanari Iida
2014-04-28 11:17 ` Jingoo Han
2014-04-30 8:43 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).